Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1319183002: [ETW] Fix wrong index in UpdateETWCategoryGroupEnabledFlags resulting in overflow. (Closed)

Created:
5 years, 3 months ago by Georges Khalil
Modified:
5 years, 3 months ago
Reviewers:
dsinclair, brucedawson
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, brucedawson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ETW] Fix wrong index in UpdateETWCategoryGroupEnabledFlags resulting in overflow. BUG=522669 Committed: https://crrev.com/f9da9005080b0ff3011bb7a060e26b739f971128 Cr-Commit-Position: refs/heads/master@{#346248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/trace_event/trace_log.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Georges Khalil
Dan, PTAL.
5 years, 3 months ago (2015-08-28 17:55:39 UTC) #2
brucedawson
It's annoying that code analysis didn't find this one. Unfortunately /analyze doesn't have good heuristics ...
5 years, 3 months ago (2015-08-28 18:30:25 UTC) #4
dsinclair
lgtm. Please fill in or remove the BUG= line.
5 years, 3 months ago (2015-08-28 18:44:31 UTC) #5
Georges Khalil
On 2015/08/28 18:44:31, dsinclair wrote: > lgtm. Please fill in or remove the BUG= line. ...
5 years, 3 months ago (2015-08-28 20:49:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319183002/1
5 years, 3 months ago (2015-08-28 20:50:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 22:28:18 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 22:29:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9da9005080b0ff3011bb7a060e26b739f971128
Cr-Commit-Position: refs/heads/master@{#346248}

Powered by Google App Engine
This is Rietveld 408576698