Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1319163004: [Extensions Page MD] Stub out a materialized extensions page (Closed)

Created:
5 years, 3 months ago by Devlin
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang, Dan Beam
CC:
chromium-reviews, extensions-reviews_chromium.org, arv+watch_chromium.org, jlklein+watch-closure_chromium.org, vitalyp+closure_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Page MD] Stub out a materialized extensions page Create a stub page for a materialized extensions page. BUG=529395 Committed: https://crrev.com/d4160a8240869e54692c8547a2bfff7bf2a4320c Cr-Commit-Position: refs/heads/master@{#347994}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -39 lines) Patch
M chrome/browser/browser_about_handler.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/browser_resources.grd View 2 chunks +4 lines, -0 lines 0 comments Download
A + chrome/browser/resources/md_extensions/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/resources/md_extensions/compiled_resources.gyp View 1 chunk +6 lines, -4 lines 0 comments Download
A chrome/browser/resources/md_extensions/extensions.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + chrome/browser/resources/md_extensions/manager.html View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/resources/md_extensions/manager.js View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/resources/md_extensions/strings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 3 chunks +45 lines, -22 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Devlin
Doesn't do anything yet. But good to get the boilerplate out of the way.
5 years, 3 months ago (2015-09-08 22:38:02 UTC) #4
Dan Beam
lgtm https://codereview.chromium.org/1319163004/diff/40001/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/1319163004/diff/40001/chrome/common/chrome_switches.cc#newcode453 chrome/common/chrome_switches.cc:453: const char kEnableMaterialDesignExtensions[] = "enable-md-extensions"; nit: below Downloads ...
5 years, 3 months ago (2015-09-09 00:05:02 UTC) #5
Devlin
https://codereview.chromium.org/1319163004/diff/40001/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/1319163004/diff/40001/chrome/common/chrome_switches.cc#newcode453 chrome/common/chrome_switches.cc:453: const char kEnableMaterialDesignExtensions[] = "enable-md-extensions"; On 2015/09/09 00:05:02, Dan ...
5 years, 3 months ago (2015-09-09 15:46:06 UTC) #6
Devlin
+thestig@ for chrome/browser/browser_about_handler.cc.
5 years, 3 months ago (2015-09-09 15:46:22 UTC) #9
Devlin
+thestig@ for chrome/browser/browser_about_handler.cc.
5 years, 3 months ago (2015-09-09 15:46:22 UTC) #10
Lei Zhang
lgtm
5 years, 3 months ago (2015-09-09 18:00:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319163004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319163004/60001
5 years, 3 months ago (2015-09-09 18:25:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/111307)
5 years, 3 months ago (2015-09-09 19:16:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319163004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319163004/60001
5 years, 3 months ago (2015-09-09 19:35:45 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 3 months ago (2015-09-09 20:26:57 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d4160a8240869e54692c8547a2bfff7bf2a4320c Cr-Commit-Position: refs/heads/master@{#347994}
5 years, 3 months ago (2015-09-09 20:28:10 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:02:55 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d4160a8240869e54692c8547a2bfff7bf2a4320c
Cr-Commit-Position: refs/heads/master@{#347994}

Powered by Google App Engine
This is Rietveld 408576698