Oilpan: Remove a redundant loop from NormalPageHeap::allocatePage()

Oilpan: Remove a redundant loop from NormalPageHeap::allocatePage()

http://codereview.chromium.org/393823003 added the loop for the purposes
of repeatedly polling the cross-thread-usable free page pool.
As we now take the first page & don't add that to the pool,
the loop looks redundant.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201903

[haraken, 2015-09-08 07:06:58]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2015-09-08 07:06:58]

PTAL

[sof, 2015-09-08 07:13:11]

https://codereview.chromium.org/1319163003/diff/1/Source/platform/heap/HeapPa...
File Source/platform/heap/HeapPage.cpp (right):

https://codereview.chromium.org/1319163003/diff/1/Source/platform/heap/HeapPa...
Source/platform/heap/HeapPage.cpp:543: RELEASE_ASSERT(result);
Don't you need to assign pageMemory?

[haraken, 2015-09-08 07:18:35]

On 2015/09/08 07:13:11, sof wrote:
>
https://codereview.chromium.org/1319163003/diff/1/Source/platform/heap/HeapPa...
> File Source/platform/heap/HeapPage.cpp (right):
> 
>
https://codereview.chromium.org/1319163003/diff/1/Source/platform/heap/HeapPa...
> Source/platform/heap/HeapPage.cpp:543: RELEASE_ASSERT(result);
> Don't you need to assign pageMemory?

Sorry, done. Confirmed webkit_unit_tests pass.

[sof, 2015-09-08 07:24:27]

lgtm

I'd be fine with doing something weaker (RELEASE_ASSERT(pageMemory); at the end
of the loop here), should commit() fail for other reasons. But I'm all for
trying this stronger condition.

[haraken, 2015-09-08 07:30:39]

> I'd be fine with doing something weaker (RELEASE_ASSERT(pageMemory); at the
end
> of the loop here), should commit() fail for other reasons. But I'm all for
> trying this stronger condition.

Yeah, I might want to understand a scenario that hits the assert.

[haraken, 2015-09-08 07:30:42]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2015-09-08 07:30:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1319163003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1319163003/20001

[commit-bot: I haz the power, 2015-09-08 08:32:24]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201903