Cleanup ResourceLoadPriority setting

Source/core/loader/FrameFetchContextTest.cpp

 /*
  * Copyright (c) 2015, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/loader/FrameFetchContext.h"
 
 #include "core/fetch/FetchInitiatorInfo.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameOwner.h"
 #include "core/frame/FrameView.h"
+#include "core/frame/Settings.h"
 #include "core/html/HTMLDocument.h"
 #include "core/loader/DocumentLoader.h"
 #include "core/loader/EmptyClients.h"
 #include "core/page/Page.h"
 #include "core/testing/DummyPageHolder.h"
 #include "platform/network/ResourceRequest.h"
 #include "platform/weborigin/KURL.h"
 #include <gtest/gtest.h>
 
 namespace blink {
 
-class FrameFetchContextUpgradeTest : public ::testing::Test {
+class StubFrameLoaderClientWithParent final : public EmptyFrameLoaderClient {

[Nate Chapin, 2015/09/01 23:54:47]

Moved without modification from farther down in the file.

+public:
+    static PassOwnPtrWillBeRawPtr<StubFrameLoaderClientWithParent> create(Frame* parent)
+    {
+        return adoptPtrWillBeNoop(new StubFrameLoaderClientWithParent(parent));
+    }
+
+    DEFINE_INLINE_VIRTUAL_TRACE()
+    {
+        visitor->trace(m_parent);
+        EmptyFrameLoaderClient::trace(visitor);
+    }
+
+    Frame* parent() const override { return m_parent.get(); }
+
+private:
+    explicit StubFrameLoaderClientWithParent(Frame* parent)
+        : m_parent(parent)
+    {
+    }
+
+    RawPtrWillBeMember<Frame> m_parent;
+};
+
+class StubFrameOwner : public NoBaseWillBeGarbageCollectedFinalized<StubFrameOwner>, public FrameOwner {

[Nate Chapin, 2015/09/01 23:54:47]

Moved without modification from farther down in the file.

+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(StubFrameOwner);
+public:
+    DEFINE_INLINE_VIRTUAL_TRACE() { FrameOwner::trace(visitor); }
+
+    bool isLocal() const override { return false; }
+    SandboxFlags sandboxFlags() const override { return SandboxNone; }
+    void dispatchLoad() override { }
+    void renderFallbackContent() override { }
+};
+
+class FrameFetchContextTest : public ::testing::Test {
+protected:
+    void SetUp() override
+    {
+        dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
+        dummyPageHolder->page().setDeviceScaleFactor(1.0);
+        documentLoader = DocumentLoader::create(&dummyPageHolder->frame(), ResourceRequest("http://www.example.com"), SubstituteData());
+        document = toHTMLDocument(&dummyPageHolder->document());
+        fetchContext = static_cast<FrameFetchContext*>(&documentLoader->fetcher()->context());
+        FrameFetchContext::provideDocumentToContext(*fetchContext, document.get());
+    }
+
+    void TearDown() override
+    {
+        documentLoader->detachFromFrame();
+        documentLoader.clear();
+
+        if (childFrame) {
+            childDocumentLoader->detachFromFrame();
+            childDocumentLoader.clear();
+            childFrame->detach(FrameDetachType::Remove);
+        }
+    }
+
+    FrameFetchContext* createChildFrame()
+    {
+        childClient = StubFrameLoaderClientWithParent::create(document->frame());
+        childFrame = LocalFrame::create(childClient.get(), document->frame()->host(), &owner);
+        childFrame->setView(FrameView::create(childFrame.get(), IntSize(500, 500)));
+        childFrame->init();
+        childDocumentLoader = DocumentLoader::create(childFrame.get(), ResourceRequest("http://www.example.com"), SubstituteData());
+        childDocument = childFrame->document();
+        FrameFetchContext* childFetchContext = static_cast<FrameFetchContext*>(&childDocumentLoader->fetcher()->context());
+        FrameFetchContext::provideDocumentToContext(*childFetchContext, childDocument.get());
+        return childFetchContext;
+    }
+
+    OwnPtr<DummyPageHolder> dummyPageHolder;
+    // We don't use the DocumentLoader directly in any tests, but need to keep it around as long
+    // as the ResourceFetcher and Document live due to indirect usage.
+    RefPtrWillBePersistent<DocumentLoader> documentLoader;

[dcheng, 2015/09/02 17:17:12]

It might be nice to update these to use the right naming convention for members
in a future patch.

+    RefPtrWillBePersistent<Document> document;
+    Persistent<FrameFetchContext> fetchContext;
+
+    OwnPtrWillBeRawPtr<StubFrameLoaderClientWithParent> childClient;
+    RefPtrWillBeRawPtr<LocalFrame> childFrame;
+    RefPtrWillBePersistent<DocumentLoader> childDocumentLoader;
+    RefPtrWillBePersistent<Document> childDocument;
+    StubFrameOwner owner;
+
+};
+
+class FrameFetchContextUpgradeTest : public FrameFetchContextTest {
 public:
     FrameFetchContextUpgradeTest()
         : secureURL(ParsedURLString, "https://secureorigin.test/image.png")

[dcheng, 2015/09/02 17:17:12]

Maybe just inline this directly into line 142? I don't see anyone else using
"secureURL".

[Nate Chapin, 2015/09/02 17:29:55]

Done.

         , exampleOrigin(SecurityOrigin::create(KURL(ParsedURLString, "https://example.test/")))
         , secureOrigin(SecurityOrigin::create(secureURL))
     {
     }
 
 protected:
-    virtual void SetUp()
-    {
-        dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
-        dummyPageHolder->page().setDeviceScaleFactor(1.0);
-        documentLoader = DocumentLoader::create(&dummyPageHolder->frame(), ResourceRequest("http://www.example.com"), SubstituteData());
-        document = toHTMLDocument(&dummyPageHolder->document());
-        fetchContext = &documentLoader->fetcher()->context();
-        FrameFetchContext::provideDocumentToContext(*fetchContext, document.get());
-    }
-
-    virtual void TearDown()
-    {
-        documentLoader->detachFromFrame();
-        documentLoader.clear();
-    }
-
     void expectUpgrade(const char* input, const char* expected)
     {
         expectUpgrade(input, WebURLRequest::RequestContextScript, WebURLRequest::FrameTypeNone, expected);
     }
 
     void expectUpgrade(const char* input, WebURLRequest::RequestContext requestContext, WebURLRequest::FrameType frameType, const char* expected)
     {
         KURL inputURL(ParsedURLString, input);
         KURL expectedURL(ParsedURLString, expected);
 
@@ skipping 21 matching lines @@
 
         fetchContext->upgradeInsecureRequest(fetchRequest);
 
         EXPECT_STREQ(shouldPrefer ? "1" : "",
             fetchRequest.resourceRequest().httpHeaderField("Upgrade-Insecure-Requests").utf8().data());
     }
 
     KURL secureURL;
     RefPtr<SecurityOrigin> exampleOrigin;
     RefPtr<SecurityOrigin> secureOrigin;
-
-    OwnPtr<DummyPageHolder> dummyPageHolder;
-    // We don't use the DocumentLoader directly in any tests, but need to keep it around as long
-    // as the ResourceFetcher and Document live due to indirect usage.
-    RefPtrWillBePersistent<DocumentLoader> documentLoader;
-    RefPtrWillBePersistent<Document> document;
-    Persistent<FetchContext> fetchContext;
 };
 
 TEST_F(FrameFetchContextUpgradeTest, UpgradeInsecureResourceRequests)
 {
     struct TestCase {
         const char* original;
         const char* upgraded;
     } tests[] = {
         { "http://example.test/image.png", "https://example.test/image.png" },
         { "http://example.test:80/image.png", "https://example.test:443/image.png" },
@@ skipping 84 matching lines @@
 
     for (const auto& test : tests) {
         document->setInsecureRequestsPolicy(SecurityContext::InsecureRequestsDoNotUpgrade);
         expectHTTPSHeader(test.toRequest, test.frameType, test.shouldPrefer);
 
         document->setInsecureRequestsPolicy(SecurityContext::InsecureRequestsUpgrade);
         expectHTTPSHeader(test.toRequest, test.frameType, test.shouldPrefer);
     }
 }
 
-class FrameFetchContextHintsTest : public ::testing::Test {
+class FrameFetchContextHintsTest : public FrameFetchContextTest {
 public:
     FrameFetchContextHintsTest() { }
 
 protected:
-    virtual void SetUp()
-    {
-        dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
-        dummyPageHolder->page().setDeviceScaleFactor(1.0);
-        documentLoader = DocumentLoader::create(&dummyPageHolder->frame(), ResourceRequest("http://www.example.com"), SubstituteData());
-        document = toHTMLDocument(&dummyPageHolder->document());
-        fetchContext = static_cast<FrameFetchContext*>(&documentLoader->fetcher()->context());
-        FrameFetchContext::provideDocumentToContext(*fetchContext, document.get());
-    }
-
-    virtual void TearDown()
-    {
-        documentLoader->detachFromFrame();
-        documentLoader.clear();
-    }
-
     void expectHeader(const char* input, const char* headerName, bool isPresent, const char* headerValue, float width = 0)
     {
         KURL inputURL(ParsedURLString, input);
         FetchRequest fetchRequest = FetchRequest(ResourceRequest(inputURL), FetchInitiatorInfo());
         if (width > 0) {
             FetchRequest::ResourceWidth resourceWidth;
             resourceWidth.width = width;
             resourceWidth.isSet = true;
             fetchRequest.setResourceWidth(resourceWidth);
         }
         fetchContext->addClientHintsIfNecessary(fetchRequest);
 
         EXPECT_STREQ(isPresent ? headerValue : "",
             fetchRequest.resourceRequest().httpHeaderField(headerName).utf8().data());
     }
-
-    OwnPtr<DummyPageHolder> dummyPageHolder;
-    // We don't use the DocumentLoader directly in any tests, but need to keep it around as long
-    // as the ResourceFetcher and Document live due to indirect usage.
-    RefPtrWillBePersistent<DocumentLoader> documentLoader;
-    RefPtrWillBePersistent<Document> document;
-    Persistent<FrameFetchContext> fetchContext;
 };
 
 TEST_F(FrameFetchContextHintsTest, MonitorDPRHints)
 {
     expectHeader("http://www.example.com/1.gif", "DPR", false, "");
     ClientHintsPreferences preferences;
     preferences.setShouldSendDPR(true);
     document->clientHintsPreferences().updateFrom(preferences);
     expectHeader("http://www.example.com/1.gif", "DPR", true, "1");
     dummyPageHolder->page().setDeviceScaleFactor(2.5);
@@ skipping 36 matching lines @@
     ClientHintsPreferences preferences;
     preferences.setShouldSendDPR(true);
     preferences.setShouldSendResourceWidth(true);
     preferences.setShouldSendViewportWidth(true);
     document->clientHintsPreferences().updateFrom(preferences);
     expectHeader("http://www.example.com/1.gif", "DPR", true, "1");
     expectHeader("http://www.example.com/1.gif", "Width", true, "400", 400);
     expectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "500");
 }
 
-class StubFrameLoaderClientWithParent final : public EmptyFrameLoaderClient {
-public:
-    static PassOwnPtrWillBeRawPtr<StubFrameLoaderClientWithParent> create(Frame* parent)
-    {
-        return adoptPtrWillBeNoop(new StubFrameLoaderClientWithParent(parent));
-    }
-
-    DEFINE_INLINE_VIRTUAL_TRACE()
-    {
-        visitor->trace(m_parent);
-        EmptyFrameLoaderClient::trace(visitor);
-    }
-
-    Frame* parent() const override { return m_parent.get(); }
-
-private:
-    explicit StubFrameLoaderClientWithParent(Frame* parent)
-        : m_parent(parent)
-    {
-    }
-
-    RawPtrWillBeMember<Frame> m_parent;
-};
-
-class StubFrameOwner : public NoBaseWillBeGarbageCollectedFinalized<StubFrameOwner>, public FrameOwner {
-    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(StubFrameOwner);
-public:
-    DEFINE_INLINE_VIRTUAL_TRACE() { FrameOwner::trace(visitor); }
-
-    bool isLocal() const override { return false; }
-    SandboxFlags sandboxFlags() const override { return SandboxNone; }
-    void dispatchLoad() override { }
-    void renderFallbackContent() override { }
-};
-
-class FrameFetchContextCachePolicyTest : public ::testing::Test {
-public:
-    FrameFetchContextCachePolicyTest() { }
-
-protected:
-    void SetUp() override
-    {
-        dummyPageHolder = DummyPageHolder::create(IntSize(500, 500));
-        dummyPageHolder->page().setDeviceScaleFactor(1.0);
-        documentLoader = DocumentLoader::create(&dummyPageHolder->frame(), ResourceRequest("http://www.example.com"), SubstituteData());
-        document = toHTMLDocument(&dummyPageHolder->document());
-        fetchContext = static_cast<FrameFetchContext*>(&documentLoader->fetcher()->context());
-        FrameFetchContext::provideDocumentToContext(*fetchContext, document.get());
-    }
-
-    void TearDown() override
-    {
-        documentLoader->detachFromFrame();
-        documentLoader.clear();
-    }
-
-    OwnPtr<DummyPageHolder> dummyPageHolder;
-    // We don't use the DocumentLoader directly in any tests, but need to keep it around as long
-    // as the ResourceFetcher and Document live due to indirect usage.
-    RefPtrWillBePersistent<DocumentLoader> documentLoader;
-    RefPtrWillBePersistent<Document> document;
-    Persistent<FrameFetchContext> fetchContext;
-};
-
-TEST_F(FrameFetchContextCachePolicyTest, MainResource)
+TEST_F(FrameFetchContextTest, MainResource)
 {
     // Default case
     ResourceRequest request("http://www.example.com");
     EXPECT_EQ(UseProtocolCachePolicy, fetchContext->resourceRequestCachePolicy(request, Resource::MainResource));
 
     // Post
     ResourceRequest postRequest("http://www.example.com");
     postRequest.setHTTPMethod("POST");
     EXPECT_EQ(ReloadIgnoringCacheData, fetchContext->resourceRequestCachePolicy(postRequest, Resource::MainResource));
 
@@ skipping 11 matching lines @@
     document->frame()->loader().setLoadType(FrameLoadTypeSame);
     EXPECT_EQ(ReloadIgnoringCacheData, fetchContext->resourceRequestCachePolicy(request, Resource::MainResource));
 
     // Conditional request
     document->frame()->loader().setLoadType(FrameLoadTypeStandard);
     ResourceRequest conditional("http://www.example.com");
     conditional.setHTTPHeaderField("If-Modified-Since", "foo");
     EXPECT_EQ(ReloadIgnoringCacheData, fetchContext->resourceRequestCachePolicy(conditional, Resource::MainResource));
 
     // Set up a child frame
-    OwnPtrWillBeRawPtr<StubFrameLoaderClientWithParent> client = StubFrameLoaderClientWithParent::create(document->frame());
-    StubFrameOwner owner;
-    RefPtrWillBeRawPtr<LocalFrame> childFrame = LocalFrame::create(client.get(), document->frame()->host(), &owner);
-    childFrame->setView(FrameView::create(childFrame.get(), IntSize(500, 500)));
-    childFrame->init();
-    RefPtrWillBePersistent<DocumentLoader> childDocumentLoader =
-        DocumentLoader::create(childFrame.get(), ResourceRequest("http://www.example.com"), SubstituteData());
-    RefPtrWillBePersistent<Document> childDocument = childFrame->document();
-    FrameFetchContext* childFetchContext = static_cast<FrameFetchContext*>(&childDocumentLoader->fetcher()->context());
-    FrameFetchContext::provideDocumentToContext(*childFetchContext, childDocument.get());
+    FrameFetchContext* childFetchContext = createChildFrame();
 
     // Child frame as part of back/forward
     document->frame()->loader().setLoadType(FrameLoadTypeBackForward);
     EXPECT_EQ(ReturnCacheDataElseLoad, childFetchContext->resourceRequestCachePolicy(request, Resource::MainResource));
 
     // Child frame as part of reload
     document->frame()->loader().setLoadType(FrameLoadTypeReload);
     EXPECT_EQ(ReloadIgnoringCacheData, childFetchContext->resourceRequestCachePolicy(request, Resource::MainResource));
 
     // Child frame as part of end to end reload
     document->frame()->loader().setLoadType(FrameLoadTypeReloadFromOrigin);
     EXPECT_EQ(ReloadBypassingCache, childFetchContext->resourceRequestCachePolicy(request, Resource::MainResource));
+}
 
-    childDocumentLoader->detachFromFrame();
-    childDocumentLoader.clear();
-    childFrame->detach(FrameDetachType::Remove);
+TEST_F(FrameFetchContextTest, ModifyPriorityForExperiments)
+{
+    Settings* settings = document->frame()->settings();
+    FetchRequest request(ResourceRequest("http://www.example.com"), FetchInitiatorInfo());
+
+    FetchRequest preloadRequest(ResourceRequest("http://www.example.com"), FetchInitiatorInfo());
+    preloadRequest.setForPreload(true);
+
+    FetchRequest deferredRequest(ResourceRequest("http://www.example.com"), FetchInitiatorInfo());
+    deferredRequest.setDefer(FetchRequest::LazyLoad);
+
+    // Start with all experiments disabled.
+    settings->setFEtchIncreaseAsyncScriptPriority(false);
+    settings->setFEtchIncreaseFontPriority(false);
+    settings->setFEtchDeferLateScripts(false);
+    settings->setFEtchIncreasePriorities(false);
+    settings->setLowPriorityIframes(false);
+
+    // Base case, no priority change. Note that this triggers m_imageFetched, which will matter for setFetchDeferLateScripts() case below.
+    EXPECT_EQ(ResourceLoadPriorityLow, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityLow, Resource::Image, request));
+
+    // Font priority with and without fetchIncreaseFontPriority()
+    EXPECT_EQ(ResourceLoadPriorityMedium, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Font, request));
+    settings->setFEtchIncreaseFontPriority(true);
+    EXPECT_EQ(ResourceLoadPriorityHigh, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Font, request));
+
+    // Basic script cases
+    EXPECT_EQ(ResourceLoadPriorityMedium, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, request));
+    EXPECT_EQ(ResourceLoadPriorityMedium, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, preloadRequest));
+
+    // Enable deferring late scripts. Preload priority should drop.
+    settings->setFEtchDeferLateScripts(true);
+    EXPECT_EQ(ResourceLoadPriorityLow, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, preloadRequest));
+
+    // Enable increasing priority of async scripts.
+    EXPECT_EQ(ResourceLoadPriorityLow, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, deferredRequest));
+    settings->setFEtchIncreaseAsyncScriptPriority(true);
+    EXPECT_EQ(ResourceLoadPriorityMedium, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, deferredRequest));
+
+    // Enable increased priorities for the remainder.
+    settings->setFEtchIncreasePriorities(true);
+
+    // Re-test font priority with increased prioriries
+    settings->setFEtchIncreaseFontPriority(false);
+    EXPECT_EQ(ResourceLoadPriorityHigh, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Font, request));
+    settings->setFEtchIncreaseFontPriority(true);
+    EXPECT_EQ(ResourceLoadPriorityVeryHigh, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Font, request));
+
+    // Re-test basic script cases and deferring late script case with increased prioriries
+    settings->setFEtchIncreasePriorities(true);
+    settings->setFEtchDeferLateScripts(false);
+    EXPECT_EQ(ResourceLoadPriorityVeryHigh, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, request));
+    EXPECT_EQ(ResourceLoadPriorityHigh, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, preloadRequest));
+
+    // Re-test deferring late scripts.
+    settings->setFEtchDeferLateScripts(true);
+    EXPECT_EQ(ResourceLoadPriorityMedium, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, preloadRequest));
+
+    // Re-test increasing priority of async scripts. Should ignore general incraesed priorities.
+    settings->setFEtchIncreaseAsyncScriptPriority(false);
+    EXPECT_EQ(ResourceLoadPriorityLow, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, deferredRequest));
+    settings->setFEtchIncreaseAsyncScriptPriority(true);
+    EXPECT_EQ(ResourceLoadPriorityMedium, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityMedium, Resource::Script, deferredRequest));
+
+    // Set up a child frame, test main resource load with and without setLowPriorityIframes()
+    FrameFetchContext* childFetchContext = createChildFrame();
+    EXPECT_EQ(ResourceLoadPriorityVeryHigh, childFetchContext->modifyPriorityForExperiments(ResourceLoadPriorityVeryHigh, Resource::MainResource, request));
+    settings->setLowPriorityIframes(true);
+    EXPECT_EQ(ResourceLoadPriorityVeryLow, childFetchContext->modifyPriorityForExperiments(ResourceLoadPriorityVeryHigh, Resource::MainResource, request));
+
+    // Ensure we don't go out of bounds
+    settings->setFEtchIncreasePriorities(true);
+    EXPECT_EQ(ResourceLoadPriorityVeryHigh, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityVeryHigh, Resource::Script, request));
+    settings->setFEtchIncreasePriorities(false);
+    settings->setFEtchDeferLateScripts(true);
+    EXPECT_EQ(ResourceLoadPriorityVeryLow, fetchContext->modifyPriorityForExperiments(ResourceLoadPriorityVeryLow, Resource::Script, preloadRequest));
 }
 
 } // namespace