Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1319133002: [es6] Implement spec compliant ToName (actually ToPropertyKey). (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@ToPrimitive
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Implement spec compliant ToName (actually ToPropertyKey). This adds a %ToName runtime entry that uses the previously introduced Object::ToName, which is based on the new Object::ToPrimitive method. Also removes the need to expose ToName in various way via the builtins and/or context. Drive-by-fix: Let %HasProperty do the ToName conversion implicitly as required. BUG=v8:4307 LOG=n Committed: https://crrev.com/c403ede42ab9ab8e1c6e6788de5c140b16502746 Cr-Commit-Position: refs/heads/master@{#30435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -35 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/debug/mirrors.js View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/macros.py View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.js View 8 chunks +1 line, -18 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M src/v8natives.js View 10 chunks +10 lines, -10 lines 0 comments Download
A test/mjsunit/harmony/to-name.js View 1 chunk +50 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319133002/1
5 years, 3 months ago (2015-08-28 09:20:31 UTC) #2
Benedikt Meurer
Hey Yang, Here's first followup cleanup for ToName. Easy peasy. Please take a look. Thanks, ...
5 years, 3 months ago (2015-08-28 09:20:57 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/4300)
5 years, 3 months ago (2015-08-28 09:22:12 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319133002/1
5 years, 3 months ago (2015-08-28 09:23:12 UTC) #8
Yang
On 2015/08/28 09:23:12, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 3 months ago (2015-08-28 09:24:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319133002/1
5 years, 3 months ago (2015-08-28 09:39:06 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 09:46:47 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 09:47:00 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c403ede42ab9ab8e1c6e6788de5c140b16502746
Cr-Commit-Position: refs/heads/master@{#30435}

Powered by Google App Engine
This is Rietveld 408576698