Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 131913006: Remove third_party/active_doc now that Chrome Frame is gone. (Closed)

Created:
6 years, 11 months ago by grt (UTC plus 2)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org, Alexei Svitkine (slow)
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -521 lines) Patch
M android_webview/tools/known_issues.py View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/active_doc/LICENSE View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/active_doc/README.chromium View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/active_doc/in_place_menu.h View 1 chunk +0 lines, -198 lines 0 comments Download
D third_party/active_doc/ole_document_impl.h View 1 chunk +0 lines, -240 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
6 years, 11 months ago (2014-01-10 01:51:53 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 11 months ago (2014-01-10 09:22:58 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 11 months ago (2014-01-10 19:18:23 UTC) #3
grt (UTC plus 2)
torne@: moving you to TBR since this is a trivial removal. Please let me know ...
6 years, 11 months ago (2014-01-13 14:43:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/131913006/1
6 years, 11 months ago (2014-01-13 14:44:34 UTC) #5
commit-bot: I haz the power
Change committed as 244516
6 years, 11 months ago (2014-01-13 16:56:38 UTC) #6
Torne
6 years, 11 months ago (2014-01-13 18:14:05 UTC) #7
Message was sent while issue was closed.
LGTM, sorry, was OOO

Powered by Google App Engine
This is Rietveld 408576698