Enable OrientationEvent only for android.

Enable OrientationEvent only for android.

BUG=181136, 331337
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245210

[maheshkk, 2014-01-09 21:59:10]

Could you please review? This is follow up patch from
https://codereview.chromium.org/132163002/

[maheshkk, 2014-01-09 22:02:55]

On 2014/01/09 21:59:10, maheshkk wrote:
> Could you please review? This is follow up patch from
> https://codereview.chromium.org/132163002/

I'm sorry. The follow up patch for this is
https://codereview.chromium.org/132203007/

That patch has not reviewed and landed yet. I guess I put up this review too
soon.

[darin (slow to review), 2014-01-10 05:44:18]

https://codereview.chromium.org/131913003/diff/1/content/child/runtime_featur...
File content/child/runtime_features.cc (right):

https://codereview.chromium.org/131913003/diff/1/content/child/runtime_featur...
content/child/runtime_features.cc:45: // Android OrientationEvent only for
android.
I think the "only for android" bit is redundant. You are inside an #if
defined(OS_ANDROID) section, and the first word of this comment also says
"Android".

[maheshkk, 2014-01-13 15:26:54]

On 2014/01/10 05:44:18, darin wrote:
>
https://codereview.chromium.org/131913003/diff/1/content/child/runtime_featur...
> File content/child/runtime_features.cc (right):
> 
>
https://codereview.chromium.org/131913003/diff/1/content/child/runtime_featur...
> content/child/runtime_features.cc:45: // Android OrientationEvent only for
> android.
> I think the "only for android" bit is redundant. You are inside an #if
> defined(OS_ANDROID) section, and the first word of this comment also says
> "Android".

Done.

[maheshkk, 2014-01-14 17:01:32]

On 2014/01/13 15:26:54, maheshkk wrote:
> On 2014/01/10 05:44:18, darin wrote:
> >
>
https://codereview.chromium.org/131913003/diff/1/content/child/runtime_featur...
> > File content/child/runtime_features.cc (right):
> > 
> >
>
https://codereview.chromium.org/131913003/diff/1/content/child/runtime_featur...
> > content/child/runtime_features.cc:45: // Android OrientationEvent only for
> > android.
> > I think the "only for android" bit is redundant. You are inside an #if
> > defined(OS_ANDROID) section, and the first word of this comment also says
> > "Android".
> 
> Done.

Darin, gentle reminder for the review.

[maheshkk, 2014-01-15 19:42:50]

Could you please review when you have couple of mins?

[darin (slow to review), 2014-01-15 20:27:43]

LGTM

[darin (slow to review), 2014-01-15 20:27:57]

On 2014/01/15 20:27:43, darin wrote:
> LGTM

(Sorry for the delayed response!)

[maheshkk, 2014-01-15 20:31:11]

On 2014/01/15 20:27:57, darin wrote:
> On 2014/01/15 20:27:43, darin wrote:
> > LGTM
> 
> (Sorry for the delayed response!)

No worries! Thanks for your time!

[commit-bot: I haz the power, 2014-01-15 21:28:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/131913003/70001

[commit-bot: I haz the power, 2014-01-15 21:28:20]

Failed to apply patch for content/child/runtime_features.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/child/runtime_features.cc
  Hunk #1 FAILED at 42.
  1 out of 1 hunk FAILED -- saving rejects to file
content/child/runtime_features.cc.rej

Patch:       content/child/runtime_features.cc
Index: content/child/runtime_features.cc
diff --git a/content/child/runtime_features.cc
b/content/child/runtime_features.cc
index
d77679acf6fcfad94435492e46fd9f503946e104..c28e3da94dff9d4e4fb3f5d24b8b33319448cf07
100644
--- a/content/child/runtime_features.cc
+++ b/content/child/runtime_features.cc
@@ -42,6 +42,7 @@ static void SetRuntimeFeatureDefaultsForPlatform() {
   WebRuntimeFeatures::enableSharedWorker(false);
   // Android does not yet support NavigatorContentUtils.
   WebRuntimeFeatures::enableNavigatorContentUtils(false);
+  WebRuntimeFeatures::enableOrientationEvent(true);
 #else
   WebRuntimeFeatures::enableNavigatorContentUtils(true);
 #endif  // defined(OS_ANDROID)

[commit-bot: I haz the power, 2014-01-15 21:45:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/131913003/170001

[commit-bot: I haz the power, 2014-01-16 03:31:50]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-16 14:23:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/131913003/170001

[commit-bot: I haz the power, 2014-01-16 16:11:29]

Change committed as 245210

[Maria, 2014-01-16 20:40:23]

A revert of this CL has been created in
https://codereview.chromium.org/130053005/ by mariakhomenko@chromium.org.

The reason for reverting is: Causes crashes on Android on loading a web page,
more details in https://code.google.com/p/chromium/issues/detail?id=335258 .