Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4623)

Unified Diff: Source/platform/heap/Handle.h

Issue 1319123003: Oilpan: Remove out-dated comments from Handle.h (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Handle.h
diff --git a/Source/platform/heap/Handle.h b/Source/platform/heap/Handle.h
index 39046ada559b1e6a46e7c7d15ea4baa19a7743dc..f1cf4b72e1e2ca3e0e481c6452ab85341ce2f415 100644
--- a/Source/platform/heap/Handle.h
+++ b/Source/platform/heap/Handle.h
@@ -357,9 +357,6 @@ public:
CrossThreadWeakPersistent(const RawPtr<U>& other) : Parent(other.get()) { }
};
-// PersistentNode must be the left-most class to let the
-// visitor->trace(static_cast<Collection*>(this)) trace the correct position.
-// FIXME: derive affinity based on the collection.
template<typename Collection>
class PersistentHeapCollectionBase : public Collection {
// We overload the various new and delete operators with using the WTF DefaultAllocator to ensure persistent
@@ -399,6 +396,7 @@ private:
NO_LAZY_SWEEP_SANITIZE_ADDRESS
void initialize()
{
+ // FIXME: Derive affinity based on the collection.
ThreadState* state = ThreadState::current();
ASSERT(state->checkThread());
m_persistentNode = state->persistentRegion()->allocatePersistentNode(this, TraceMethodDelegate<PersistentHeapCollectionBase<Collection>, &PersistentHeapCollectionBase<Collection>::trace>::trampoline);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698