Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3292)

Unified Diff: chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js

Issue 1319093003: Use new earcons in ChromeVox Next. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@automation_node_id_fix_2
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js
diff --git a/chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js b/chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js
similarity index 68%
rename from chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js
rename to chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js
index 500da1a1e4825b75a2782ed54ac0ad4690b922e8..d1729c96ca57b9ff84806d1bbda7d5b6376d9f27 100644
--- a/chrome/browser/resources/chromeos/chromevox/host/chrome/earcons_background.js
+++ b/chrome/browser/resources/chromeos/chromevox/host/chrome/classic_earcons.js
@@ -9,7 +9,7 @@
*/
-goog.provide('cvox.EarconsBackground');
+goog.provide('cvox.ClassicEarcons');
goog.require('cvox.AbstractEarcons');
@@ -18,21 +18,22 @@ goog.require('cvox.AbstractEarcons');
* @constructor
* @extends {cvox.AbstractEarcons}
*/
-cvox.EarconsBackground = function() {
+cvox.ClassicEarcons = function() {
goog.base(this);
- this.audioMap = new Object();
if (localStorage['earcons'] === 'false') {
- this.enabled = false;
+ cvox.AbstractEarcons.enabled = false;
}
+
+ this.audioMap = new Object();
};
-goog.inherits(cvox.EarconsBackground, cvox.AbstractEarcons);
+goog.inherits(cvox.ClassicEarcons, cvox.AbstractEarcons);
/**
* @return {string} The human-readable name of the earcon set.
*/
-cvox.EarconsBackground.prototype.getName = function() {
+cvox.ClassicEarcons.prototype.getName = function() {
return 'ChromeVox earcons';
};
@@ -40,22 +41,20 @@ cvox.EarconsBackground.prototype.getName = function() {
/**
* @return {string} The base URL for loading earcons.
*/
-cvox.EarconsBackground.prototype.getBaseUrl = function() {
- return cvox.EarconsBackground.BASE_URL;
+cvox.ClassicEarcons.prototype.getBaseUrl = function() {
+ return cvox.ClassicEarcons.BASE_URL;
};
/**
* @override
*/
-cvox.EarconsBackground.prototype.playEarcon = function(earcon) {
+cvox.ClassicEarcons.prototype.playEarcon = function(earcon) {
goog.base(this, 'playEarcon', earcon);
- if (!this.enabled) {
+ if (!cvox.AbstractEarcons.enabled) {
return;
}
- if (window['console']) {
- window['console']['log']('Earcon ' + earcon);
- }
+ console.log('Earcon ' + earcon);
this.currentAudio = this.audioMap[earcon];
if (!this.currentAudio) {
@@ -78,4 +77,4 @@ cvox.EarconsBackground.prototype.playEarcon = function(earcon) {
* The base URL for loading eracons.
* @type {string}
*/
-cvox.EarconsBackground.BASE_URL = 'chromevox/background/earcons/';
+cvox.ClassicEarcons.BASE_URL = 'chromevox/background/earcons/';

Powered by Google App Engine
This is Rietveld 408576698