Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2277)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 1319093003: Use new earcons in ChromeVox Next. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@automation_node_id_fix_2
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
index 8bdf42b41fa5b5a2eca2584157bf897dc1e2320b..903e3d299c61681d829da893b8e26173f150f533 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
@@ -13,11 +13,13 @@ goog.provide('global');
goog.require('AutomationPredicate');
goog.require('AutomationUtil');
goog.require('ClassicCompatibility');
+goog.require('Cvox2EarconsBackground');
goog.require('Output');
goog.require('Output.EventType');
goog.require('cursors.Cursor');
goog.require('cvox.BrailleKeyCommand');
goog.require('cvox.ChromeVoxEditableTextBase');
+goog.require('cvox.EarconsBackground');
goog.require('cvox.ExtensionBridge');
goog.require('cvox.NavBraille');
@@ -116,6 +118,12 @@ Background = function() {
break;
}
}.bind(this));
+
+ /** @type {!cvox.AbstractEarcons} @private */
+ this.classicEarcons_ = new cvox.EarconsBackground();
+
+ /** @type {!cvox.AbstractEarcons} @private */
+ this.nextEarcons_ = new Cvox2EarconsBackground();
};
Background.prototype = {
@@ -708,6 +716,12 @@ Background.prototype = {
}
}.bind(this));
+ if (mode === ChromeVoxMode.FORCE_NEXT || mode === ChromeVoxMode.NEXT) {
Peter Lundblad 2015/09/07 21:15:52 I think this means that classic could play cvox2 e
dmazzoni 2015/09/07 23:43:04 My intent here is that you get classic earcons in
+ cvox.ChromeVox.earcons = this.nextEarcons_;
+ } else {
+ cvox.ChromeVox.earcons = this.classicEarcons_;
+ }
+
this.mode_ = mode;
},

Powered by Google App Engine
This is Rietveld 408576698