Use new earcons in ChromeVox Next.

chrome/browser/resources/chromeos/chromevox/host/interface/abstract_earcons.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Base class for implementing earcons.
  *
  * When adding earcons, please add them to getEarconName and getEarconId.
  *
  */
@@ skipping 19 matching lines @@
   LIST_ITEM: 'list_item',
   LONG_DESC: 'long_desc',
   MATH: 'math',
   OBJECT_CLOSE: 'object_close',
   OBJECT_ENTER: 'object_enter',
   OBJECT_EXIT: 'object_exit',
   OBJECT_OPEN: 'object_open',
   OBJECT_SELECT: 'object_select',
   PAGE_FINISH_LOADING: 'page_finish_loading',
   PAGE_START_LOADING: 'page_start_loading',
+  POP_UP_BUTTON: 'pop_up_button',
   RECOVER_FOCUS: 'recover_focus',
   SELECTION: 'selection',
   SELECTION_REVERSE: 'selection_reverse',
   SKIP: 'skip',
+  SLIDER: 'slider',
   WRAP: 'wrap',
   WRAP_EDGE: 'wrap_edge',
 };
 
 
 /**
  * @constructor
  */
 cvox.AbstractEarcons = function() {
-  /**
-   * Public flag set to enable or disable earcons. Callers should prefer
-   * toggle(); however, this member is public for initialization.
-   * @type {boolean}
-   */
-  this.enabled = true;
+  if (localStorage['earcons'] === 'false') {

[Peter Lundblad, 2015/10/14 12:27:26]

If we're running in the content script, what local storage are we reading?
Is it shared with the page or the cvox extension or something else?

[dmazzoni, 2015/10/14 16:13:28]

It appears to be shared.

To be safe I moved this initialization to ClassicEarcons and NextEarcons. I
didn't want to duplicate, but this seems safer, and plus we'll be getting rid of
ClassicEarcons after a while.

+    cvox.AbstractEarcons.enabled = false;
+  }
 };
 
 
 /**
+ * Public static flag set to enable or disable earcons. Callers should prefer
+ * toggle(); however, this member is public for initialization.
+ * @type {boolean}
+ */
+cvox.AbstractEarcons.enabled = true;
+
+
+/**
  * Plays the specified earcon sound.
  * @param {cvox.Earcon} earcon An earcon identifier.
  */
 cvox.AbstractEarcons.prototype.playEarcon = function(earcon) {
 };
 
 
 /**
  * Whether or not earcons are available.
  * @return {boolean} True if earcons are available.
  */
 cvox.AbstractEarcons.prototype.earconsAvailable = function() {
   return true;
 };
 
 
 /**
  * Toggles earcons on or off.
  * @return {boolean} True if earcons are now enabled; false otherwise.
  */
 cvox.AbstractEarcons.prototype.toggle = function() {

[Peter Lundblad, 2015/10/14 12:27:26]

I find it slightly unexpected to have an instance method that changes the global
state. If we go this route, consider moving it from the prototype to the class.

[dmazzoni, 2015/10/14 16:13:28]

The content script extends it, though - it sends the message to the background
page.

-  this.enabled = !this.enabled;
-  return this.enabled;
+  cvox.AbstractEarcons.enabled = !cvox.AbstractEarcons.enabled;
+  return cvox.AbstractEarcons.enabled;
 };