Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1319083003: Ignore filter property in CSS Animations (Closed)

Created:
5 years, 3 months ago by alancutter (OOO until 2018)
Modified:
5 years, 3 months ago
Reviewers:
dstockwell
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ignore filter property in CSS Animations A common pattern on the web is to animate both -webkit-filter and filter. -webkit-filter can currently be composited while filter cannot. Composited animations are not started if there are non-compositable properties being animated simultaneously. This patch ignores filter in CSS keyframes so that animations using -webkit-filter and filter will run on the compositor. Once -webkit-filter becomes an alias for filter we can stop ignoring filter in CSS Animations. BUG=520610 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201522

Patch Set 1 #

Patch Set 2 : Move skip #

Patch Set 3 : -\n #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
A LayoutTests/virtual/threaded/animations/composited-filter-webkit-filter.html View 1 chunk +30 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
alancutter (OOO until 2018)
5 years, 3 months ago (2015-08-31 05:29:30 UTC) #2
dstockwell
lgtm
5 years, 3 months ago (2015-08-31 05:35:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319083003/1
5 years, 3 months ago (2015-08-31 05:50:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/105638)
5 years, 3 months ago (2015-08-31 06:44:50 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319083003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319083003/20001
5 years, 3 months ago (2015-09-01 01:56:52 UTC) #9
alancutter (OOO until 2018)
On 2015/08/31 at 05:35:23, dstockwell wrote: > lgtm Needed to change implementation as it was ...
5 years, 3 months ago (2015-09-01 01:57:02 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319083003/40001
5 years, 3 months ago (2015-09-01 01:58:09 UTC) #12
dstockwell
lgtm
5 years, 3 months ago (2015-09-01 03:08:00 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-01 04:10:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319083003/40001
5 years, 3 months ago (2015-09-01 05:24:49 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 05:29:49 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201522

Powered by Google App Engine
This is Rietveld 408576698