Make ThemeService not disable uninstalled themes

chrome/browser/themes/theme_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/themes/theme_service.h"
 
 #include "base/files/file_util.h"
 #include "base/path_service.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_service_test_base.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/browser/themes/custom_theme_supplier.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chrome/test/base/testing_profile_manager.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/test_extension_registry_observer.h"
 #include "extensions/browser/uninstall_reason.h"
 #include "extensions/common/extension.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(ENABLE_SUPERVISED_USERS)
 #include "chrome/browser/supervised_user/supervised_user_service.h"
 #include "chrome/browser/supervised_user/supervised_user_service_factory.h"
@@ skipping 200 matching lines @@
   EXPECT_TRUE(registry_->GetExtensionById(extension1_id,
                                           ExtensionRegistry::DISABLED));
 
   // 2) Upgrading a disabled theme should not change the current theme.
   UpdateUnpackedTheme(extension1_id);
   EXPECT_EQ(extension2_id, theme_service->GetThemeID());
   EXPECT_TRUE(registry_->GetExtensionById(extension1_id,
                                           ExtensionRegistry::DISABLED));
 }
 
+namespace {
+
+// NotificationObserver which emulates an infobar getting destroyed when the
+// theme changes.
+class InfobarDestroyerOnThemeChange : public content::NotificationObserver {
+ public:
+  InfobarDestroyerOnThemeChange(Profile* profile)
+      : theme_service_(ThemeServiceFactory::GetForProfile(profile)) {
+    registrar_.Add(this, chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
+        content::Source<ThemeService>(theme_service_));
+  }
+
+  ~InfobarDestroyerOnThemeChange() override {}
+
+ private:
+  void Observe(int type,
+               const content::NotificationSource& source,
+               const content::NotificationDetails& details) override {
+    theme_service_->OnInfobarDestroyed();
+  }
+
+  // Not owned.
+  ThemeService* theme_service_;
+
+  content::NotificationRegistrar registrar_;
+
+  DISALLOW_COPY_AND_ASSIGN(InfobarDestroyerOnThemeChange);
+};
+
+}  // namespace
+
+// crbug.com/468280
+TEST_F(ThemeServiceTest, UninstallThemeOnThemeChangeNotification) {
+  // Setup.
+  ThemeService* theme_service =
+      ThemeServiceFactory::GetForProfile(profile_.get());
+  theme_service->UseDefaultTheme();
+  // Let the ThemeService uninstall unused themes.
+  base::MessageLoop::current()->RunUntilIdle();
+
+  base::ScopedTempDir temp_dir1;
+  ASSERT_TRUE(temp_dir1.CreateUniqueTempDir());
+  base::ScopedTempDir temp_dir2;
+  ASSERT_TRUE(temp_dir2.CreateUniqueTempDir());
+
+  const std::string& extension1_id = LoadUnpackedThemeAt(temp_dir1.path());
+  ASSERT_EQ(extension1_id, theme_service->GetThemeID());
+
+  // Show an infobar.
+  theme_service->OnInfobarDisplayed();
+
+  // Install another theme. Emulate the infobar destroying itself (and
+  // causing unused themes to be uninstalled) as a result of the
+  // NOTIFICATION_BROWSER_THEME_CHANGED notification.
+  {
+    InfobarDestroyerOnThemeChange destroyer(profile_.get());
+    const std::string& extension2_id = LoadUnpackedThemeAt(temp_dir2.path());
+    ASSERT_EQ(extension2_id, theme_service->GetThemeID());
+    ASSERT_FALSE(service_->GetInstalledExtension(extension1_id));
+  }
+
+  // Check that it is possible to reinstall extension1.
+  ASSERT_EQ(extension1_id, LoadUnpackedThemeAt(temp_dir1.path()));
+  EXPECT_EQ(extension1_id, theme_service->GetThemeID());
+}
+
 #if defined(ENABLE_SUPERVISED_USERS)
 class ThemeServiceSupervisedUserTest : public ThemeServiceTest {
  public:
   ThemeServiceSupervisedUserTest() {}
   ~ThemeServiceSupervisedUserTest() override {}
 
   void SetUp() override {
     is_supervised_ = true;
     ThemeServiceTest::SetUp();
   }
@@ skipping 21 matching lines @@
   theme_service->UseDefaultTheme();
   EXPECT_TRUE(theme_service->UsingDefaultTheme());
   EXPECT_TRUE(get_theme_supplier(theme_service));
   EXPECT_EQ(get_theme_supplier(theme_service)->get_theme_type(),
             CustomThemeSupplier::SUPERVISED_USER_THEME);
 }
 #endif // defined(OS_LINUX) && !defined(OS_CHROMEOS)
 #endif // defined(ENABLE_SUPERVISED_USERS)
 
 }; // namespace theme_service_internal