Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1319063004: Make gyp_flag_compare.py work on Windows (Closed)

Created:
5 years, 3 months ago by Tomasz Moniuszko
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make gyp_flag_compare.py work on Windows BUG= Committed: https://crrev.com/d9838e11893e2f80ae1d0d25dd9e8d6c41697f79 Cr-Commit-Position: refs/heads/master@{#348113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -21 lines) Patch
M tools/gn/bin/gyp_flag_compare.py View 5 chunks +74 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Tomasz Moniuszko
5 years, 3 months ago (2015-09-09 14:34:56 UTC) #2
brettw
lgtm
5 years, 3 months ago (2015-09-09 21:55:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319063004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319063004/1
5 years, 3 months ago (2015-09-10 07:22:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 07:34:30 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d9838e11893e2f80ae1d0d25dd9e8d6c41697f79 Cr-Commit-Position: refs/heads/master@{#348113}
5 years, 3 months ago (2015-09-10 07:35:31 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:08:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d9838e11893e2f80ae1d0d25dd9e8d6c41697f79
Cr-Commit-Position: refs/heads/master@{#348113}

Powered by Google App Engine
This is Rietveld 408576698