Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 13190018: Merge 147181 "[chromium] Use widget.parent() for plugin WebMouse..." (Closed)

Created:
7 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 8 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1453/
Visibility:
Public.

Description

Merge 147181 "[chromium] Use widget.parent() for plugin WebMouse..." > [chromium] Use widget.parent() for plugin WebMouseEvents > https://bugs.webkit.org/show_bug.cgi?id=113543 > > Reviewed by James Robinson. > > In r142571 I switches widget.parent() to widget.root() in the plugin > WebCore event -> WebMouseEvent creator, to make the converter the > inverse of the one going the other way and avoid null pointer crashes. > But the plugin code expects it to be parent() (see > http://crbug.com/223335). > > * src/WebInputEventConversion.cpp: > (WebKit::updateWebMouseEventFromWebCoreMouseEvent): > TBR=aelias@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -2 lines) Patch
M Source/WebKit/chromium/ChangeLog View 1 chunk +294 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/WebInputEventConversion.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aelias_OOO_until_Jul13
7 years, 8 months ago (2013-04-01 22:00:15 UTC) #1
aelias_OOO_until_Jul13
7 years, 8 months ago (2013-04-01 22:00:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r147366.

Powered by Google App Engine
This is Rietveld 408576698