Add a UseCounter for clip CSS or -webkit-clip-path that clips positioned descendants.

Add a UseCounter for clip CSS or -webkit-clip-path that clips positioned descendants.

BUG=527617
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201840

[chrishtr, 2015-09-04 22:43:14]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2015-09-04 22:43:15]

The CL as-is over-counts cases when the element with a clip is an ancestor of
the containing block of the positioned descendant, but I decided that was too
complicated to use-count. Maybe just this use-count will give us enough
information.

[pdr., 2015-09-04 22:55:14]

https://codereview.chromium.org/1318963006/diff/1/LayoutTests/paint/deprecati...
File LayoutTests/paint/deprecation/css-clip-and-clip-path.html (right):

https://codereview.chromium.org/1318963006/diff/1/LayoutTests/paint/deprecati...
LayoutTests/paint/deprecation/css-clip-and-clip-path.html:28: background:
url('https://upload.wikimedia.org/wikipedia/commons/thumb/e/e2/Google_Chrome_icon_%282011%29.svg/200px-Google_Chrome_icon_%282011%29.svg.png');
Please use an image from the repo so we don't waste wikipedia's bandwidth (or
use background: papayawhip).

https://codereview.chromium.org/1318963006/diff/1/Source/core/paint/Deprecate...
File Source/core/paint/DeprecatedPaintLayerClipper.cpp (right):

https://codereview.chromium.org/1318963006/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayerClipper.cpp:88: ClipRect rect =
intersection(newClip, clipRects.posClipRect());
Please use some ampersands here.

https://codereview.chromium.org/1318963006/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayerClipper.cpp:91: }
nit: newline

[chrishtr, 2015-09-04 23:39:00]

https://codereview.chromium.org/1318963006/diff/1/LayoutTests/paint/deprecati...
File LayoutTests/paint/deprecation/css-clip-and-clip-path.html (right):

https://codereview.chromium.org/1318963006/diff/1/LayoutTests/paint/deprecati...
LayoutTests/paint/deprecation/css-clip-and-clip-path.html:28: background:
url('https://upload.wikimedia.org/wikipedia/commons/thumb/e/e2/Google_Chrome_icon_%282011%29.svg/200px-Google_Chrome_icon_%282011%29.svg.png');
On 2015/09/04 at 22:55:14, pdr wrote:
> Please use an image from the repo so we don't waste wikipedia's bandwidth (or
use background: papayawhip).

Fixed

https://codereview.chromium.org/1318963006/diff/1/Source/core/paint/Deprecate...
File Source/core/paint/DeprecatedPaintLayerClipper.cpp (right):

https://codereview.chromium.org/1318963006/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayerClipper.cpp:88: ClipRect rect =
intersection(newClip, clipRects.posClipRect());
On 2015/09/04 at 22:55:14, pdr wrote:
> Please use some ampersands here.

Done

https://codereview.chromium.org/1318963006/diff/1/Source/core/paint/Deprecate...
Source/core/paint/DeprecatedPaintLayerClipper.cpp:91: }
On 2015/09/04 at 22:55:14, pdr wrote:
> nit: newline

Done

[pdr., 2015-09-05 00:07:48]

LGTM

https://codereview.chromium.org/1318963006/diff/40001/Source/core/paint/Depre...
File Source/core/paint/DeprecatedPaintLayerClipper.cpp (right):

https://codereview.chromium.org/1318963006/diff/40001/Source/core/paint/Depre...
Source/core/paint/DeprecatedPaintLayerClipper.cpp:88: const ClipRect& rect& =
intersection(newClip, clipRects.posClipRect());
One too many ampersands!

[chrishtr, 2015-09-05 00:21:16]

https://codereview.chromium.org/1318963006/diff/40001/Source/core/paint/Depre...
File Source/core/paint/DeprecatedPaintLayerClipper.cpp (right):

https://codereview.chromium.org/1318963006/diff/40001/Source/core/paint/Depre...
Source/core/paint/DeprecatedPaintLayerClipper.cpp:88: const ClipRect& rect& =
intersection(newClip, clipRects.posClipRect());
On 2015/09/05 at 00:07:48, pdr wrote:
> One too many ampersands!

Fixed.

[chrishtr, 2015-09-05 00:21:50]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-09-05 00:21:50]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1318963006/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-09-05 00:21:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1318963006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1318963006/80001

[commit-bot: I haz the power, 2015-09-05 02:51:42]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201840