Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1318953002: [ServiceWorker] Use appopriate type parameters for WebCallbacks (2/3) (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Use appopriate type parameters for WebCallbacks (2/3) - WebServiceWorkerRegistration* (ownership transferred) => WebPassOwnPtr<WebServiceWorkerRegistration> - WebVector<WebServiceWorkerRegistration*> (ownership transferred) => WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>> - WebServiceWorkerError* (ownership transferred) => const WebServiceWorkerError& This CL also fixes mis-typing between WebServiceWorkerRegistrationCallbacks and WebServiceWorkerGetRegistrationCallbacks. 1/3: https://codereview.chromium.org/1312343004/ 2/3: https://codereview.chromium.org/1318953002/ 3/3: https://codereview.chromium.org/1316293002/ BUG=493531, 525340 Committed: https://crrev.com/2befe77d596b9a2507b695181c130eb3b9540a1e Cr-Commit-Position: refs/heads/master@{#345955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M content/child/service_worker/service_worker_dispatcher.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 11 chunks +19 lines, -17 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yhirano
5 years, 3 months ago (2015-08-27 13:38:53 UTC) #2
nhiroki
LGTM
5 years, 3 months ago (2015-08-27 14:05:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318953002/1
5 years, 3 months ago (2015-08-27 18:51:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 19:45:42 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2befe77d596b9a2507b695181c130eb3b9540a1e Cr-Commit-Position: refs/heads/master@{#345955}
5 years, 3 months ago (2015-08-27 19:46:24 UTC) #7
nhiroki
5 years, 3 months ago (2015-09-04 03:01:40 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1325153007/ by nhiroki@chromium.org.

The reason for reverting is: According to http://crbug.com/523904 (see c#11),
these callbacks will not always receive object ownership and not be able to use
WebPassOwnPtr, so let me revert this series of CLs..

Powered by Google App Engine
This is Rietveld 408576698