Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: runtime/vm/exceptions.cc

Issue 1318943005: Update range errors to agree on the numbers. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: More tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/exceptions.cc
diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc
index de44cf021f1bcb8fe8d957f462ee08b3ac0d7075..9f99503e8b2b3730c09659c46880b8cde39b5ca3 100644
--- a/runtime/vm/exceptions.cc
+++ b/runtime/vm/exceptions.cc
@@ -571,7 +571,7 @@ void Exceptions::ThrowRangeError(const char* argument_name,
args.SetAt(1, Integer::Handle(Integer::New(expected_from)));
args.SetAt(2, Integer::Handle(Integer::New(expected_to)));
args.SetAt(3, String::Handle(String::New(argument_name)));
- Exceptions::ThrowByType(Exceptions::kRangeRange, args);
+ Exceptions::ThrowByType(Exceptions::kRange, args);
}
@@ -588,10 +588,6 @@ RawObject* Exceptions::Create(ExceptionType type, const Array& arguments) {
case kRange:
library = Library::CoreLibrary();
class_name = &Symbols::RangeError();
- break;
- case kRangeRange:
- library = Library::CoreLibrary();
- class_name = &Symbols::RangeError();
constructor_name = &Symbols::DotRange();
break;
case kArgument:

Powered by Google App Engine
This is Rietveld 408576698