Update range errors to agree on the numbers.

sdk/lib/core/errors.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.core;
 
 /**
  * Error objects thrown in the case of a program failure.
  *
  * An `Error` object represents a program failure that the programmer
@@ skipping 371 matching lines @@
              [String name, String message, int length])
       : this.indexable = indexable,
         this.length = (length != null) ? length : indexable.length,
         super.value(invalidValue, name,
                     (message != null) ? message : "Index out of range");
 
   // Getters inherited from RangeError.
   int get start => 0;
   int get end => length - 1;
 
   String get _errorName => "RangeError";

[sra1, 2015/09/09 17:16:05]

Was this supposed to be "IndexError"?

[Lasse Reichstein Nielsen, 2015/09/10 10:08:54]

No, this was introduced as a helper class for a special group of range errors.
It's not important that it's a separate class unless you actually care about it.

   String get _errorExplanation {
     assert(_hasValue);
-    String target = Error.safeToString(indexable);
-    var explanation = ": index should be less than $length";
     if (invalidValue < 0) {
-      explanation = ": index must not be negative";
+      return ": index must not be negative";
     }
-    return explanation;
+    if (length == 0) {
+      return ": no indices are valid";

[sra1, 2015/09/09 17:16:05]

I find this a tiny bit confusing.
It would be nice if the error said the list was empty, but that assumes the
indexable is a List.

[Lasse Reichstein Nielsen, 2015/09/10 10:08:54]

Exactly my problem (and what I started out saying). It does read rather
awkwardly.

Suggestions would be appreciated!

+    }
+    return ": index should be less than $length";
   }
 }
 
 
 /**
  * Error thrown when control reaches the end of a switch case.
  *
  * The Dart specification requires this error to be thrown when
  * control reaches the end of a switch case (except the last case
  * of a switch) without meeting a break or similar end of the control
@@ skipping 151 matching lines @@
  * the first time it is read. If evaluating the initializer expression causes
  * another read of the variable, this error is thrown.
  */
 class CyclicInitializationError extends Error {
   final String variableName;
   CyclicInitializationError([this.variableName]);
   String toString() => variableName == null
       ? "Reading static variable during its initialization"
       : "Reading static variable '$variableName' during its initialization";
 }