Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1318943002: Move global function lowestEditableAncestor() to local function in VisibleSelection.cpp (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move global function lowestEditableAncestor() to local function in VisibleSelection.cpp This patch moves global function |lowestEditableAncestor()| in "EditingUtilities.{cpp,h}" to local function in "VisibleSelection.cpp" to narrow visibility for improving code health and ease of implement composed tree version. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201302

Patch Set 1 : 2015-08-27T17:01:49 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M Source/core/editing/EditingUtilities.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-27 08:29:48 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-27 08:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318943002/1
5 years, 3 months ago (2015-08-27 08:50:20 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 09:31:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201302

Powered by Google App Engine
This is Rietveld 408576698