Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1318933006: Revert of Add command_buffer_gles2 (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add command_buffer_gles2 (patchset #14 id:310001 of https://codereview.chromium.org/1220883008/ ) Reason for revert: Doesn't build on 64-bit Windows gn: http://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/1743 FAILED: C:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:./command_buffer_gles2.dll.lib /DLL /OUT:./command_buffer_gles2.dll /PDB:./command_buffer_gles2.dll.pdb @./command_buffer_gles2.dll.rsp gpu.dll.lib(gpu.dll) :error LNK2005: "public: __cdecl gpu::gles2::GLES2CmdHelper::GLES2CmdHelper(class gpu::CommandBuffer *)" (??0GLES2CmdHelper@gles2@gpu@@QEAA@PEAVCommandBuffer@2@@Z) already defined in gles2_cmd_helper.obj gpu.dll.lib(gpu.dll) :error LNK2005: "public: bool __cdecl gpu::CommandBufferHelper::Initialize(int)" (?Initialize@CommandBufferHelper@gpu@@QEAA_NH@Z) already defined in cmd_buffer_helper.obj gpu.dll.lib(gpu.dll) :error LNK2005: "public: __cdecl gpu::TransferBuffer::TransferBuffer(class gpu::CommandBufferHelper *)" (??0TransferBuffer@gpu@@QEAA@PEAVCommandBufferHelper@1@@Z) already defined in transfer_buffer.obj gpu.dll.lib(gpu.dll) :error LNK2005: "public: void __cdecl base::RefCounted<class gpu::ValueStateMap>::Release(void)const " (?Release@?$RefCounted@VValueStateMap@gpu@@@base@@QEBAXXZ) already defined in value_state.obj gpu.dll.lib(gpu.dll) :error LNK2005: "public: void __cdecl base::RefCounted<class gpu::ValueStateMap>::AddRef(void)const " (?AddRef@?$RefCounted@VValueStateMap@gpu@@@base@@QEBAXXZ) already defined in value_state.obj Original issue's description: > Add command_buffer_gles2 > > This is a very simple library that exposes some egl-like functions that > can be used by skia to use the command buffer as a backend for their > tests > > Committed: https://crrev.com/604b615373e4e9f873db37cef9c6416176fc35f3 > Cr-Commit-Position: refs/heads/master@{#346251} > > Committed: https://crrev.com/efa3a446183fbbff2034a03989f12543d0713e39 > Cr-Commit-Position: refs/heads/master@{#346840} > > Committed: https://crrev.com/d65c55dac3f47e9a237579eb6f5fe31e19ca4704 > Cr-Commit-Position: refs/heads/master@{#347013} TBR=piman@chromium.org,dpranke@chromium.org,sievers@chromium.org,hendrikw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a3ce89c68f8d70a7047fe5d2fbcf5819fa95b7d0 Cr-Commit-Position: refs/heads/master@{#347069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -211 lines) Patch
M gpu/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 2 chunks +0 lines, -12 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M gpu/gles2_conform_support/egl/egl.cc View 14 chunks +117 lines, -127 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Add command_buffer_gles2
5 years, 3 months ago (2015-09-03 00:10:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318933006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318933006/1
5 years, 3 months ago (2015-09-03 00:31:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 00:35:51 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 00:37:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3ce89c68f8d70a7047fe5d2fbcf5819fa95b7d0
Cr-Commit-Position: refs/heads/master@{#347069}

Powered by Google App Engine
This is Rietveld 408576698