Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1318933004: [Tick processor] Add an option to the tick-processor to print the summary. (Closed)

Created:
5 years, 3 months ago by gdeepti1
Modified:
5 years, 3 months ago
CC:
v8-dev, bradnelson
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Tick processor] Add an option to the tick-processor to print the summary. - Print the summary excluding other tick information - Add test to verify that summary is printed correctly. BUG=None LOG=N R=machenbach@chromium.org Committed: https://crrev.com/e1f38de76a758f8640685f5b3afc0d153f0abd86 Cr-Commit-Position: refs/heads/master@{#30573}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review comments from Jakob and Michael. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -37 lines) Patch
M test/mjsunit/tools/tickprocessor.js View 1 3 chunks +14 lines, -7 lines 0 comments Download
A test/mjsunit/tools/tickprocessor-test.only-summary View 1 1 chunk +9 lines, -0 lines 0 comments Download
M tools/tickprocessor.js View 1 7 chunks +39 lines, -29 lines 0 comments Download
M tools/tickprocessor-driver.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
gdeepti1
5 years, 3 months ago (2015-09-02 21:00:42 UTC) #1
Michael Achenbach
Tentative lgtm. Adding more accurate owner. https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js File tools/tickprocessor.js (right): https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js#newcode517 tools/tickprocessor.js:517: } nit: indentation ...
5 years, 3 months ago (2015-09-03 08:19:11 UTC) #4
Jakob Kummerow
LGTM with comments. https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js File tools/tickprocessor.js (right): https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js#newcode461 tools/tickprocessor.js:461: var printAllTicks = this.printSummary_ == undefined ...
5 years, 3 months ago (2015-09-03 08:37:08 UTC) #5
gdeepti1
https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js File tools/tickprocessor.js (right): https://codereview.chromium.org/1318933004/diff/1/tools/tickprocessor.js#newcode461 tools/tickprocessor.js:461: var printAllTicks = this.printSummary_ == undefined || On 2015/09/03 ...
5 years, 3 months ago (2015-09-03 17:50:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318933004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318933004/20001
5 years, 3 months ago (2015-09-03 18:00:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-03 18:01:47 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 18:01:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1f38de76a758f8640685f5b3afc0d153f0abd86
Cr-Commit-Position: refs/heads/master@{#30573}

Powered by Google App Engine
This is Rietveld 408576698