Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 131893003: Skeleton surface interfaces in cc/surfaces (Closed)

Created:
6 years, 11 months ago by jamesr
Modified:
6 years, 11 months ago
CC:
chromium-reviews, jbauman+watch_chromium.org, ben+aura_chromium.org, Ian Vollick, jam, piman+watch_chromium.org, sievers+watch_chromium.org, joi+watch-content_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, kalyank, sadrul, cc-bugs_chromium.org, android-webview-reviews_chromium.org, aelias_OOO_until_Jul13, piman, danakj
Visibility:
Public.

Description

Skeleton surface interfaces in cc/surfaces This adds a very basic surface class with tests under cc/surfaces to establish gyp and DEPS rules. While this system is under early development it shouldn't be used by anything outside of unit tests. BUG=334090 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245137

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : add base and ui/gfx deps to fix win/mac component link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -1 line) Patch
M android_webview/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M cc/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc.gyp View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A cc/surfaces/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A cc/surfaces/surface.h View 1 chunk +37 lines, -0 lines 0 comments Download
A cc/surfaces/surface.cc View 1 chunk +24 lines, -0 lines 0 comments Download
A cc/surfaces/surface_manager.h View 1 chunk +39 lines, -0 lines 0 comments Download
A cc/surfaces/surface_manager.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A cc/surfaces/surface_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A cc/surfaces/surfaces_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M content/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/bench/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/DEPS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
The idea here is to start landing the surface implementation code in cc/surfaces/ but try ...
6 years, 11 months ago (2014-01-14 02:44:39 UTC) #1
Ben Goodger (Google)
deps lgtm
6 years, 11 months ago (2014-01-14 03:26:25 UTC) #2
enne (OOO)
lgtm
6 years, 11 months ago (2014-01-14 19:05:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/131893003/140001
6 years, 11 months ago (2014-01-15 23:23:05 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 05:22:33 UTC) #5
Message was sent while issue was closed.
Change committed as 245137

Powered by Google App Engine
This is Rietveld 408576698