Issue 1318913004: [CodeHealth][Editing] Refactor EphemeralRange::isNull/isNotNull impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1318913004: [CodeHealth][Editing] Refactor EphemeralRange::isNull/isNotNull impl. (Closed)

Created:
5 years, 3 months ago by yoichio

Modified:
5 years, 3 months ago

Reviewers:
yosin_UTC9

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

[CodeHealth][Editing] Refactor EphemeralRange::isNull/isNotNull impl. Replace null with isNull in comment because 'null' means nullptr typically. We prefer not to use double negation so reverse impl in isNull and isNotNull. It gets straightforward. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201297

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
	M	Source/core/editing/EphemeralRange.h	View		2 chunks	+8 lines, -4 lines	0 comments	Download
	M	Source/core/editing/EphemeralRange.cpp	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318913004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318913004/1

5 years, 3 months ago (2015-08-27 08:44:24 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-08-27 08:49:04 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201297

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages