Source/devtools/front_end/emulation/MediaQueryInspector.js - Issue 1318903007: Devtools UI: Fix tooltip issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/emulation/MediaQueryInspector.js

Issue 1318903007: Devtools UI: Fix tooltip issues (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/elements/ElementsTreeElement.js ('K') | « Source/devtools/front_end/elements/ElementsTreeElement.js ('k') | Source/devtools/front_end/ui/Tooltip.js » ('j') | Source/devtools/front_end/ui/Tooltip.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/emulation/MediaQueryInspector.js

diff --git a/Source/devtools/front_end/emulation/MediaQueryInspector.js b/Source/devtools/front_end/emulation/MediaQueryInspector.js

index 6624d38a1b3c416f3249bc8b0f042e43c7dc6c91..46ad19c93da694dae026f76c120b01b4b51fbb4a 100644

--- a/Source/devtools/front_end/emulation/MediaQueryInspector.js

+++ b/Source/devtools/front_end/emulation/MediaQueryInspector.js

@@ -341,7 +341,10 @@ WebInspector.MediaQueryInspector.prototype = {

var labelContainer = markerElement.createChild("div", "media-inspector-marker-label-container media-inspector-marker-label-container-right");

labelContainer.createChild("span", "media-inspector-marker-label " + labelClass).textContent = model.maxWidthExpression().value() + model.maxWidthExpression().unit();

}

- markerElement.title = model.mediaText();

+ var tooltipOptions = {};

+ tooltipOptions[WebInspector.Tooltip.Options.VerticalAlignmentTop] = true;

+ tooltipOptions[WebInspector.Tooltip.Options.HorizontalAlignUnderCursor] = true;

+ WebInspector.Tooltip.install(markerElement, model.mediaText(), "", tooltipOptions);

return markerElement;