Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318903005: Move mojom to public/dart (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 3 months ago
Reviewers:
zra
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -1013 lines) Patch
M mojo/dart/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/dart/mojom/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/dart/mojom/CHANGELOG.md View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/dart/mojom/README.md View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/dart/mojom/lib/README.md View 1 chunk +0 lines, -5 lines 0 comments Download
D mojo/dart/mojom/lib/generate.dart View 1 chunk +0 lines, -249 lines 0 comments Download
D mojo/dart/mojom/lib/src/options.dart View 1 chunk +0 lines, -123 lines 0 comments Download
D mojo/dart/mojom/lib/src/utils.dart View 1 chunk +0 lines, -100 lines 0 comments Download
D mojo/dart/mojom/pubspec.lock View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/dart/mojom/pubspec.yaml View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/dart/mojom/test/generate_test.dart View 1 chunk +0 lines, -390 lines 0 comments Download
M mojo/public/dart/.gitignore View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/dart/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
A + mojo/public/dart/mojom/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
A + mojo/public/dart/mojom/CHANGELOG.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/dart/mojom/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/dart/mojom/lib/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/dart/mojom/lib/generate.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/dart/mojom/lib/src/options.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/dart/mojom/lib/src/utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/dart/mojom/pubspec.lock View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/dart/mojom/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/dart/mojom/test/generate_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/tools/get_test_list.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 3 months ago (2015-08-27 19:22:51 UTC) #2
zra
lgtm
5 years, 3 months ago (2015-08-27 19:24:57 UTC) #3
Cutch
5 years, 3 months ago (2015-08-27 19:34:09 UTC) #4
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
b0d4161e5a3e2f9ebc64e1d67a6df415ba51bea5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698