Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1318893002: [turbofan] LiveRange splinter merging optimizations. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] LiveRange splinter merging optimizations. A few benchmarks, e.g. Massive/SQLite, turn out to be sensitive to compile time. Upon analysis, splinter merging and then splinter creation (splitting) appear to be the main contributors to such regressions. This change tackles main sources of regression in Merging. Profiling SQLite shows, after this change, Merging as noise (down from main C++ contributor of samples) BUG=chromium:524880 LOG=n Committed: https://crrev.com/1c6139de8bb4d26c2ce0278091388d5838311666 Cr-Commit-Position: refs/heads/master@{#30400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -24 lines) Patch
M src/compiler/register-allocator.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.cc View 5 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-08-27 01:03:47 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-08-27 04:42:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318893002/1
5 years, 3 months ago (2015-08-27 04:43:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 04:44:38 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 04:44:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c6139de8bb4d26c2ce0278091388d5838311666
Cr-Commit-Position: refs/heads/master@{#30400}

Powered by Google App Engine
This is Rietveld 408576698