Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1318883007: Fix the build for clang 3.8 and MINIMAL=1. (Closed)

Created:
5 years, 3 months ago by ascull
Modified:
5 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the build for clang 3.8 and MINIMAL=1. 3.8 has stricter warnings which LLVM doesn't pass so we turn them off when including the offending headers. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2c688f62f53fcf719bacce32ca615a582ce5c40b

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M src/IceClFlagsExtra.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceGlobalInits.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceTargetLoweringARM32.cpp View 3 chunks +2 lines, -4 lines 2 comments Download
M src/IceTypeConverter.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ascull
Thanks to jpp@ for the fix.
5 years, 3 months ago (2015-09-09 18:44:40 UTC) #2
Jim Stichnoth
lgtm https://codereview.chromium.org/1318883007/diff/1/src/IceTargetLoweringARM32.cpp File src/IceTargetLoweringARM32.cpp (left): https://codereview.chromium.org/1318883007/diff/1/src/IceTargetLoweringARM32.cpp#oldcode59 src/IceTargetLoweringARM32.cpp:59: const size_t TableIcmp32Size = llvm::array_lengthof(TableIcmp32); I assume the ...
5 years, 3 months ago (2015-09-09 18:52:00 UTC) #3
ascull
https://codereview.chromium.org/1318883007/diff/1/src/IceTargetLoweringARM32.cpp File src/IceTargetLoweringARM32.cpp (left): https://codereview.chromium.org/1318883007/diff/1/src/IceTargetLoweringARM32.cpp#oldcode59 src/IceTargetLoweringARM32.cpp:59: const size_t TableIcmp32Size = llvm::array_lengthof(TableIcmp32); On 2015/09/09 18:52:00, stichnot ...
5 years, 3 months ago (2015-09-09 18:55:06 UTC) #4
ascull
5 years, 3 months ago (2015-09-09 18:56:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c688f62f53fcf719bacce32ca615a582ce5c40b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698