Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2081)

Issue 131883002: Android: changes the JNI generator to use long by default. (Closed)

Created:
6 years, 11 months ago by bulach
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android: changes the JNI generator to use long by default. BUG=317523 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/jni_generator.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
bulach
thanks for the heads up Chris! there quite a few changes in the under review ...
6 years, 11 months ago (2014-01-09 16:22:44 UTC) #1
bulach
ping? :)
6 years, 11 months ago (2014-01-15 15:56:52 UTC) #2
cjhopman
Sorry, I'm OOO. lgtm, though.
6 years, 11 months ago (2014-01-18 18:11:39 UTC) #3
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 10 months ago (2014-02-04 21:14:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/131883002/1
6 years, 10 months ago (2014-02-04 22:33:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/131883002/1
6 years, 10 months ago (2014-02-05 01:13:48 UTC) #6
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-05 19:50:55 UTC) #7
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-05 19:53:48 UTC) #8
bulach
The CQ bit was unchecked by bulach@chromium.org
6 years, 10 months ago (2014-02-06 02:47:23 UTC) #9
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 10 months ago (2014-02-06 02:47:31 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-06 09:24:37 UTC) #11
commit-bot: I haz the power
List of reviewers changed. phajdan.jr@chromium.org did a drive-by without LGTM'ing!
6 years, 10 months ago (2014-02-06 09:24:38 UTC) #12
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 10 months ago (2014-02-06 18:39:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/131883002/1
6 years, 10 months ago (2014-02-06 18:41:55 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 18:46:46 UTC) #15
Message was sent while issue was closed.
Change committed as 249461

Powered by Google App Engine
This is Rietveld 408576698