Issue 1318823012: SkTraceMemoryDump_Chrome: fix -Wreorder warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1318823012: SkTraceMemoryDump_Chrome: fix -Wreorder warning (Closed)

Created:
5 years, 3 months ago by hans

Modified:
5 years, 3 months ago

Reviewers:
ssid

CC:
chromium-reviews, Nico

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

SkTraceMemoryDump_Chrome: fix -Wreorder warning Clang on Windows (is this file only built on Windows?) was failing with: ..\..\skia\ext\SkTraceMemoryDump_chrome.cc(25,7) : error: field 'dump_name_prefix_' will be initialized after field 'process_memory_dump_' [-Werror,-Wreorder] : dump_name_prefix_(dump_name_prefix), ^ BUG=82385 TBR=ssid Committed: https://crrev.com/f17572a3c8ba9cc987d69fbd8a461fe621a89c83 Cr-Commit-Position: refs/heads/master@{#347414}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	skia/ext/SkTraceMemoryDump_chrome.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318823012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318823012/1

5 years, 3 months ago (2015-09-04 15:40:05 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/f17572a3c8ba9cc987d69fbd8a461fe621a89c83 Cr-Commit-Position: refs/heads/master@{#347414}

5 years, 3 months ago (2015-09-04 15:50:25 UTC) #5

Message was sent while issue was closed.

LGTM, thanks.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages