Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: third_party/brotli/BUILD.gn

Issue 1318823008: Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/brotli/BUILD.gn
diff --git a/third_party/brotli/BUILD.gn b/third_party/brotli/BUILD.gn
index 2975f036df401585fe627b329471ad62c7bc65e9..f18c8020f135aa91e0a9219d36256585397267d4 100644
--- a/third_party/brotli/BUILD.gn
+++ b/third_party/brotli/BUILD.gn
@@ -2,6 +2,15 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+config("brotli_warnings") {
+ if (is_clang) {
+ # IncrementalCopyFastPath in decode.c can be unused.
+ # (The file looks very different upstream, this is probably no longer
+ # needed after rolling brotli the next time.)
+ cflags = [ "-Wno-unused-function" ]
+ }
+}
+
source_set("brotli") {
sources = [
"dec/bit_reader.c",
@@ -23,17 +32,11 @@ source_set("brotli") {
"dec/types.h",
]
- config("brotli_warnings") {
- if (is_clang) {
- # IncrementalCopyFastPath in decode.c can be unused.
- # (The file looks very different upstream, this is probably no longer
- # needed after rolling brotli the next time.)
- cflags = [ "-Wno-unused-function" ]
- }
- }
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
- configs += [ ":brotli_warnings" ]
+ configs += [
+ ":brotli_warnings",
+ "//build/config/compiler:no_chromium_code",
+ ]
# Since we are never debug brotli, freeze the optimizations to -O2.
if (is_debug) {
« no previous file with comments | « sdch/BUILD.gn ('k') | third_party/cld_2/BUILD.gn » ('j') | third_party/harfbuzz-ng/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698