Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: third_party/libxslt/BUILD.gn

Issue 1318823008: Un-nest configs in GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("libxslt_config") { 5 config("libxslt_config") {
6 defines = [ "LIBXSLT_STATIC" ] 6 defines = [ "LIBXSLT_STATIC" ]
7 include_dirs = [ "." ] 7 include_dirs = [ "." ]
8 } 8 }
9 9
10 config("libxslt_warnings") {
11 if (is_clang) {
12 cflags = [
13 # libxslt stores a char[3] in a `const unsigned char*`.
14 "-Wno-pointer-sign",
15
16 # xsltDefaultRegion and xsltCalibrateTimestamps are only
17 # used with certain preprocessor defines set.
18 "-Wno-unused-function",
19 ]
20 }
21 }
22
10 static_library("libxslt") { 23 static_library("libxslt") {
11 sources = [ 24 sources = [
12 "libxslt/attributes.c", 25 "libxslt/attributes.c",
13 "libxslt/attributes.h", 26 "libxslt/attributes.h",
14 "libxslt/attrvt.c", 27 "libxslt/attrvt.c",
15 "libxslt/documents.c", 28 "libxslt/documents.c",
16 "libxslt/documents.h", 29 "libxslt/documents.h",
17 "libxslt/extensions.c", 30 "libxslt/extensions.c",
18 "libxslt/extensions.h", 31 "libxslt/extensions.h",
19 "libxslt/extra.c", 32 "libxslt/extra.c",
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 "libxslt/xsltlocale.c", 65 "libxslt/xsltlocale.c",
53 "libxslt/xsltlocale.h", 66 "libxslt/xsltlocale.h",
54 "libxslt/xsltutils.c", 67 "libxslt/xsltutils.c",
55 "libxslt/xsltutils.h", 68 "libxslt/xsltutils.h",
56 "libxslt/xsltwin32config.h", 69 "libxslt/xsltwin32config.h",
57 "linux/config.h", 70 "linux/config.h",
58 "mac/config.h", 71 "mac/config.h",
59 "win32/config.h", 72 "win32/config.h",
60 ] 73 ]
61 74
62 config("libxslt_warnings") {
63 if (is_clang) {
64 cflags = [
65 # libxslt stores a char[3] in a `const unsigned char*`.
66 "-Wno-pointer-sign",
67
68 # xsltDefaultRegion and xsltCalibrateTimestamps are only
69 # used with certain preprocessor defines set.
70 "-Wno-unused-function",
71 ]
72 }
73 }
74 configs -= [ "//build/config/compiler:chromium_code" ] 75 configs -= [ "//build/config/compiler:chromium_code" ]
75 configs += [ "//build/config/compiler:no_chromium_code" ] 76 configs += [
76 configs += [ ":libxslt_warnings" ] 77 ":libxslt_warnings",
78 "//build/config/compiler:no_chromium_code",
79 ]
77 public_configs = [ ":libxslt_config" ] 80 public_configs = [ ":libxslt_config" ]
78 81
79 cflags = [] 82 cflags = []
80 if (is_linux || is_android) { 83 if (is_linux || is_android) {
81 include_dirs = [ "linux" ] 84 include_dirs = [ "linux" ]
82 } else if (is_win) { 85 } else if (is_win) {
83 include_dirs = [ "win32" ] 86 include_dirs = [ "win32" ]
84 cflags += [ "/wd4267" ] # size_t to int. 87 cflags += [ "/wd4267" ] # size_t to int.
85 } else if (is_mac) { 88 } else if (is_mac) {
86 include_dirs = [ "mac" ] 89 include_dirs = [ "mac" ]
87 } 90 }
88 91
89 deps = [ 92 deps = [
90 "//third_party/libxml", 93 "//third_party/libxml",
91 ] 94 ]
92 } 95 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698