Issue 1318813005: Revert of Fix reftest crash logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1318813005: Revert of Fix reftest crash logs (Closed)

Created:
5 years, 3 months ago by pdr.

Modified:
5 years, 3 months ago

Reviewers:
Dirk Pranke, joelo, ojan

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of Fix reftest crash logs (patchset #1 id:1 of https://codereview.chromium.org/1312693002/ ) Reason for revert: May be causing win failures, see http://crbug.com/524248#50 Original issue's description: > Fix reftest crash logs > > This patch fixes a long-standing bug where crashing reftests would not > show some crash logs on the layout tests results page. > > single_test_runner.py has an optimization to not run reftests when > the base test crashes. This optimization accidentally failed to write > crash logs (done through write_test_result(...)) as well. This patch > fixes this bug and adds a small test. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201147 TBR=dpranke@chromium.org,joelo@chromium.org,ojan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201249

Patch Set 1 #

Created: 5 years, 3 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -15 lines)			Patch
M	Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/test.py	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318813005/1

5 years, 3 months ago (2015-08-26 21:39:00 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-08-26 21:39:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201249

Expand Messages | Collapse Messages