Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318773003: Move remoting/base/resources* to remoting/host (Closed)

Created:
5 years, 3 months ago by Sergey Ulanov
Modified:
5 years, 3 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move remoting/base/resources* to remoting/host base/resources.h is used only in host, so it doesn't need to be in base. Committed: https://crrev.com/b9d14401ecbc0641a27c24fbe987a7803e258f8f Cr-Commit-Position: refs/heads/master@{#345719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -203 lines) Patch
M remoting/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D remoting/base/resources.h View 1 chunk +0 lines, -23 lines 0 comments Download
D remoting/base/resources_linux.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D remoting/base/resources_mac.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D remoting/base/resources_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D remoting/base/resources_win.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M remoting/host/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/host/host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/host/resources.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/host/resources_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/host/resources_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + remoting/host/resources_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
A + remoting/host/resources_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/remoting.gyp View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/remoting_test.gypi View 3 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
5 years, 3 months ago (2015-08-26 20:03:25 UTC) #2
Lambros
lgtm
5 years, 3 months ago (2015-08-26 21:00:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318773003/1
5 years, 3 months ago (2015-08-26 22:13:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 23:23:51 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 23:24:37 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b9d14401ecbc0641a27c24fbe987a7803e258f8f
Cr-Commit-Position: refs/heads/master@{#345719}

Powered by Google App Engine
This is Rietveld 408576698