Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: components/metrics/call_stack_profile_metrics_provider.h

Issue 1318733007: Refactor CallStackProfile::Params into base/ for use over IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/call_stack_profile_metrics_provider.h
diff --git a/components/metrics/call_stack_profile_metrics_provider.h b/components/metrics/call_stack_profile_metrics_provider.h
index d368c99c4ace94222b512b746d79bb3b49db290c..0f9c00590e3987d6b203920d1564a2ce84c8d6da 100644
--- a/components/metrics/call_stack_profile_metrics_provider.h
+++ b/components/metrics/call_stack_profile_metrics_provider.h
@@ -8,6 +8,7 @@
#include <vector>
#include "base/memory/ref_counted.h"
+#include "base/metrics/call_stack_profile_params.h"
#include "base/profiler/stack_sampling_profiler.h"
#include "components/metrics/metrics_provider.h"
@@ -25,24 +26,6 @@ class CallStackProfileMetricsProvider : public MetricsProvider {
THREAD_HUNG
};
- // Parameters to pass back to the metrics provider.
- struct Params {
- explicit Params(Trigger trigger);
- Params(Trigger trigger, bool preserve_sample_ordering);
-
- // The triggering event.
- Trigger trigger;
-
- // True if sample ordering is important and should be preserved when the
- // associated profiles are compressed. This should only be set to true if
- // the intended use of the requires that the sequence of call stacks within
- // a particular profile be preserved. The default value of false provides
- // better compression of the encoded profile and is sufficient for the
- // typical use case of recording profiles for stack frequency analysis in
- // aggregate.
- bool preserve_sample_ordering;
- };
-
CallStackProfileMetricsProvider();
~CallStackProfileMetricsProvider() override;
@@ -51,7 +34,7 @@ class CallStackProfileMetricsProvider : public MetricsProvider {
// StackSamplingProfiler, and should not be reused between
// StackSamplingProfilers. This function may be called on any thread.
static base::StackSamplingProfiler::CompletedCallback GetProfilerCallback(
- const Params& params);
+ const base::CallStackProfileParams& params);
// MetricsProvider:
void OnRecordingEnabled() override;

Powered by Google App Engine
This is Rietveld 408576698