chrome/browser/chrome_browser_main.cc - Issue 1318733007: Refactor CallStackProfile::Params into base/ for use over IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 1318733007: Refactor CallStackProfile::Params into base/ for use over IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index 42b815d2c28421d91bb3cbcfee17e00601e9881d..2a9a250736ad0c21398a49b23d363d5159a1825d 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -15,6 +15,7 @@

#include "base/debug/debugger.h"

#include "base/files/file_path.h"

#include "base/files/file_util.h"

+#include "base/metrics/call_stack_profile_params.h"

#include "base/metrics/field_trial.h"

#include "base/metrics/histogram_macros.h"

#include "base/path_service.h"

@@ -586,8 +587,8 @@ ChromeBrowserMainParts::ChromeBrowserMainParts(

base::PlatformThread::CurrentId(),

GetStartupSamplingParams(),

metrics::CallStackProfileMetricsProvider::GetProfilerCallback(

- metrics::CallStackProfileMetricsProvider::Params(

- metrics::CallStackProfileMetricsProvider::PROCESS_STARTUP,

+ base::CallStackProfileParams(

+ base::CallStackProfileParams::PROCESS_STARTUP,

false))),

profile_(NULL),

run_message_loop_(true),

« base/metrics/call_stack_profile_params.cc ('K') | « base/metrics/call_stack_profile_params.cc ('k') | chrome/browser/metrics/thread_watcher.cc » ('j') | no next file with comments »