Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: chrome/browser/metrics/thread_watcher.cc

Issue 1318733007: Refactor CallStackProfile::Params into base/ for use over IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/thread_watcher.cc
diff --git a/chrome/browser/metrics/thread_watcher.cc b/chrome/browser/metrics/thread_watcher.cc
index 7fcbbf158d8f670e330feb23e86bfca8c6b00363..a7a49f74836965252c33a603383dad8936120e00 100644
--- a/chrome/browser/metrics/thread_watcher.cc
+++ b/chrome/browser/metrics/thread_watcher.cc
@@ -11,6 +11,7 @@
#include "base/debug/dump_without_crashing.h"
#include "base/lazy_instance.h"
#include "base/location.h"
+#include "base/metrics/call_stack_profile_params.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "base/strings/string_tokenizer.h"
@@ -951,12 +952,10 @@ bool JankTimeBomb::IsEnabled() const {
void JankTimeBomb::Alarm(base::PlatformThreadId thread_id) {
DCHECK(WatchDogThread::CurrentlyOnWatchDogThread());
sampling_profiler_.reset(new base::StackSamplingProfiler(
- thread_id,
- GetJankTimeBombSamplingParams(),
+ thread_id, GetJankTimeBombSamplingParams(),
Mike Wittman 2015/08/31 19:35:57 nit: move GetJankTimeBombSamplingParams(), to next
sydli 2015/08/31 20:09:42 Done.
metrics::CallStackProfileMetricsProvider::GetProfilerCallback(
- metrics::CallStackProfileMetricsProvider::Params(
- metrics::CallStackProfileMetricsProvider::JANKY_TASK,
- true))));
+ base::CallStackProfileParams(base::CallStackProfileParams::JANKY_TASK,
+ true))));
// Use synchronous profiler. It will automatically stop collection when
// destroyed.
sampling_profiler_->Start();

Powered by Google App Engine
This is Rietveld 408576698