base/metrics/call_stack_profile_params.cc - Issue 1318733007: Refactor CallStackProfile::Params into base/ for use over IPC.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/metrics/call_stack_profile_params.cc

Issue 1318733007: Refactor CallStackProfile::Params into base/ for use over IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/metrics/call_stack_profile_params.h"

	6

	7 namespace base {

	8

	9 CallStackProfileParams::CallStackProfileParams() {}
	erikchen 2015/08/31 19:09:15 don't we need to initialize members? don't we need to initialize members? Mike Wittman 2015/08/31 19:35:57 We do. Show quoted text On 2015/08/31 19:09:15, erikchen wrote: > don't we need to initialize members? We do. sydli 2015/08/31 20:09:42 Done. Show quoted text On 2015/08/31 19:35:57, Mike Wittman wrote: > On 2015/08/31 19:09:15, erikchen wrote: > > don't we need to initialize members? > > We do. Done.
	10

	11 CallStackProfileParams::CallStackProfileParams(

	12 base::CallStackProfileParams::Trigger trigger)

	13 : CallStackProfileParams(trigger, false) {}

	14

	15 CallStackProfileParams::CallStackProfileParams(

	16 base::CallStackProfileParams::Trigger trigger,

	17 bool preserve_sample_ordering)

	18 : trigger(trigger), preserve_sample_ordering(preserve_sample_ordering) {}

	19

	20 } // namespace base

OLD	NEW