cc: Do the math for a tile's content rect in layer space once.

cc/tiles/tile.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/tiles/tile.h"
 
 #include <algorithm>
 
 #include "base/numerics/safe_conversions.h"
 #include "base/trace_event/trace_event_argument.h"
 #include "cc/base/math_util.h"
 #include "cc/debug/traced_value.h"
 #include "cc/tiles/tile_manager.h"
 
 namespace cc {
 
 Tile::Id Tile::s_next_id_ = 1;
 
 Tile::Tile(TileManager* tile_manager,
-           const gfx::Size& desired_texture_size,
-           const gfx::Rect& content_rect,
-           float contents_scale,
+           const CreateInfo& info,

[vmpstr, 2015/08/28 21:05:30]

Also, why not just store the info?

[danakj, 2015/08/31 21:12:12]

Well, that would add a lot of indirections/typing in the code, and I don't see a
strong benefit. It would save a few lines in the constructor basically. I like
it a lot for plumbing, but less so as a storage type basically.

[vmpstr, 2015/08/31 21:15:10]

Makes sense.

            int layer_id,
            int source_frame_number,
            int flags)
     : tile_manager_(tile_manager),
-      desired_texture_size_(desired_texture_size),
-      content_rect_(content_rect),
-      contents_scale_(contents_scale),
+      content_rect_(info.content_rect),
+      enclosing_layer_rect_(info.enclosing_layer_rect),
+      contents_scale_(info.contents_scale),
       layer_id_(layer_id),
       source_frame_number_(source_frame_number),
       flags_(flags),
-      tiling_i_index_(-1),
-      tiling_j_index_(-1),
+      tiling_i_index_(info.tiling_i_index),
+      tiling_j_index_(info.tiling_j_index),
       required_for_activation_(false),
       required_for_draw_(false),
       id_(s_next_id_++),
       invalidated_id_(0),
-      scheduled_priority_(0) {
-}
+      scheduled_priority_(0) {}
 
 Tile::~Tile() {
   TRACE_EVENT_OBJECT_DELETED_WITH_ID(
       TRACE_DISABLED_BY_DEFAULT("cc.debug"),
       "cc::Tile", this);
 }
 
 void Tile::AsValueInto(base::trace_event::TracedValue* value) const {
   TracedValue::MakeDictIntoImplicitSnapshotWithCategory(
       TRACE_DISABLED_BY_DEFAULT("cc.debug"), value, "cc::Tile", this);
@@ skipping 20 matching lines @@
   if (draw_info_.resource_) {
     // We can use UncheckedSizeInBytes, since the tile size is determined by the
     // compositor.
     return ResourceUtil::UncheckedSizeInBytes<size_t>(
         draw_info_.resource_->size(), draw_info_.resource_->format());
   }
   return 0;
 }
 
 void Tile::Deleter::operator()(Tile* tile) const {
-  TileManager* tile_manager = tile->tile_manager_;
-  tile_manager->Release(tile);
+  tile->tile_manager_->Release(tile);
 }
 
 }  // namespace cc