Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318713007: [Atomics] Remove support for atomic accesses on floating-point values. (Closed)

Created:
5 years, 3 months ago by binji
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Atomics] Remove support for atomic accesses on floating-point values. R=jarin@chromium.org Committed: https://crrev.com/f5bec4bcd4961f967cef04086b5b5c1720fcdec0 Cr-Commit-Position: refs/heads/master@{#30755}

Patch Set 1 #

Patch Set 2 : fix windows #

Total comments: 2

Patch Set 3 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -278 lines) Patch
M src/harmony-atomics.js View 4 chunks +3 lines, -9 lines 0 comments Download
M src/runtime/runtime-atomics.cc View 1 2 16 chunks +31 lines, -158 lines 0 comments Download
M test/mjsunit/asm/atomics-compareexchange.js View 1 4 chunks +0 lines, -20 lines 0 comments Download
M test/mjsunit/asm/atomics-load.js View 1 4 chunks +0 lines, -16 lines 0 comments Download
M test/mjsunit/asm/atomics-store.js View 1 4 chunks +0 lines, -18 lines 0 comments Download
M test/mjsunit/harmony/atomics.js View 1 8 chunks +6 lines, -57 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
binji
The latest spec no longer supports atomic floats.
5 years, 3 months ago (2015-08-31 22:09:51 UTC) #1
Jarin
On 2015/08/31 22:09:51, binji wrote: > The latest spec no longer supports atomic floats. It ...
5 years, 3 months ago (2015-09-01 04:43:01 UTC) #2
Jarin
lgtm with a nit. https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-atomics.cc File src/runtime/runtime-atomics.cc (right): https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-atomics.cc#newcode490 src/runtime/runtime-atomics.cc:490: case kExternalFloat64Array: Does it really ...
5 years, 3 months ago (2015-09-03 08:23:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318713007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318713007/40001
5 years, 3 months ago (2015-09-15 20:50:50 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-15 21:24:57 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f5bec4bcd4961f967cef04086b5b5c1720fcdec0 Cr-Commit-Position: refs/heads/master@{#30755}
5 years, 3 months ago (2015-09-15 21:25:26 UTC) #8
binji
5 years, 3 months ago (2015-09-16 17:15:45 UTC) #9
Message was sent while issue was closed. 
https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-ato...
File src/runtime/runtime-atomics.cc (right):

https://codereview.chromium.org/1318713007/diff/20001/src/runtime/runtime-ato...
src/runtime/runtime-atomics.cc:490: case kExternalFloat64Array:
On 2015/09/03 at 08:23:32, Jarin wrote:
> Does it really make sense to mention the float cases explicitly here? If yes,
could you remove the default case?

Removed.

Powered by Google App Engine
This is Rietveld 408576698