Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Issue 1318693002: [turbofan] Fix broken dynamic TDZ check for let and const. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
Dan Ehrenberg, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix broken dynamic TDZ check for let and const. This fixes broken dynamic hole-checks for the temporal dead zone of non-initializing assignments to {let} and {const} declared variables. Also note that this exemplifies a case where the dynamic check for such assignments to {let} declared variables can no longer be elided as the comment suggested. R=rossberg@chromium.org TEST=mjsunit/regress/regress-4388 BUG=v8:4388 LOG=n Committed: https://crrev.com/cbd4f5aa98eb82f5ef68c7163f2fd4f27b958e67 Cr-Commit-Position: refs/heads/master@{#30375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -5 lines 0 comments Download
A test/mjsunit/regress/regress-4388.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
Andreas: PTAL. Dan: FYI.
5 years, 3 months ago (2015-08-26 08:28:37 UTC) #2
rossberg
lgtm
5 years, 3 months ago (2015-08-26 09:29:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318693002/1
5 years, 3 months ago (2015-08-26 09:51:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 09:53:04 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 09:53:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbd4f5aa98eb82f5ef68c7163f2fd4f27b958e67
Cr-Commit-Position: refs/heads/master@{#30375}

Powered by Google App Engine
This is Rietveld 408576698