Make cvox2 feedback more robust when focusing a text field.

chrome/browser/resources/chromeos/chromevox/testing/mock_feedback.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview This file contains the |MockFeedback| class which is a
  * combined mock class for speech and braille feedback.  A test that uses
  * this class may add expectations for speech utterances and braille display
  * content to be output.  The |install| method sets appropriate mock classes
  * as the |cvox.ChromeVox.tts| and |cvox.ChromeVox.braille| objects,
@@ skipping 123 matching lines @@
           return !!MockFeedback.matchAndConsume_(
               text, {}, this.pendingUtterances_);
         }.bind(this),
         toString: function() { return 'Speak \'' + text + '\''; }
       });
     }.bind(this));
     return this;
   },
 
   /**
+   * Adds an expectation that a given utterance will not be spoken.
+   * @param {...(string|RegExp)} var_args One or more utterance to add as
+   *     negative expectations.
+   * @return {MockFeedback} |this| for chaining
+   */
+  expectNoSpeech: function() {

[Peter Lundblad, 2015/08/26 16:56:13]

I think this only works if the unexpected utterance comes first in the queue.
Perhaps that's good enough, but would be good to document.

[dmazzoni, 2015/08/26 18:18:23]

Good point. How about expectNextSpeechUtteranceIsNot()

+    assertFalse(this.replaying_);
+    Array.prototype.forEach.call(arguments, function(text) {
+      this.pendingActions_.push({
+        perform: function() {
+          if (this.pendingUtterances_.length == 0)
+            return false;
+          if (MockFeedback.matchAndConsume_(
+                  text, {}, this.pendingUtterances_)) {
+            throw new Error('Got disallowed utterance "' + text + '".');
+          }
+          return true;
+        }.bind(this),
+        toString: function() { return 'Do not speak \'' + text + '\''; }
+      });
+    }.bind(this));
+    return this;
+  },
+
+  /**
    * Adds an expectation for braille output.
    * @param {string|RegExp} text
    * @param {Object=} opt_props Additional properties to match in the
    *     |NavBraille|
    * @return {MockFeedback} |this| for chaining
    */
   expectBraille: function(text, opt_props) {
     assertFalse(this.replaying_);
     var props = opt_props || {};
     this.pendingActions_.push({
@@ skipping 57 matching lines @@
     return this.lastMatchedBraille_;
   },
 
   /**
    * @param {string} textString
    * @param {cvox.QueueMode} queueMode
    * @param {Object=} properties
    * @private
    */
   addUtterance_: function(textString, queueMode, properties) {
+    console.log('*** ADDUTTERANCE ' + textString);

[Peter Lundblad, 2015/08/26 16:56:13]

Intentional?

[dmazzoni, 2015/08/26 18:18:23]

Oops, meant to remove that. Is there a way to add a VLOG from JS that I could
turn on temporarily while debugging, like in C++? When a test fails sometimes
it's nice to see exactly what MockFeedback got.

     var callback;
     if (properties && (properties.startCallback || properties.endCallback)) {
       var startCallback = properties.startCallback;
       var endCallback = properties.endCallback;
       callback = function() {
         startCallback && startCallback();
         endCallback && endCallback();
       };
     }
     this.pendingUtterances_.push(
@@ skipping 92 matching lines @@
   }
   if (candidate) {
     var consumed = pending.splice(0, i + 1);
     consumed.forEach(function(item) {
       if (item.callback)
         item.callback();
     });
   }
   return candidate;
 };