Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1318663007: skia: use msaaConfigAttribList for SkOSWindow_win (Closed)

Created:
5 years, 3 months ago by hendrikw
Modified:
5 years, 3 months ago
Reviewers:
reed2, robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skia: use msaaConfigAttribList for SkOSWindow_win eglChooseConfig was still being passed configAttribList, pass msaaConfigAttribList instead Committed: https://skia.googlesource.com/skia/+/151202990091b69fbe8521d9a51e7310b45e3449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/views/win/SkOSWindow_win.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
hendrikw
Happened to notice this when looking through the code, PTAL, thanks
5 years, 3 months ago (2015-09-04 22:34:13 UTC) #2
hendrikw
5 years, 3 months ago (2015-09-04 22:34:52 UTC) #4
robertphillips
lgtm
5 years, 3 months ago (2015-09-08 12:42:10 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318663007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318663007/1
5 years, 3 months ago (2015-09-08 12:42:30 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-08 12:47:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318663007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318663007/1
5 years, 3 months ago (2015-09-08 12:52:52 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 12:53:27 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/151202990091b69fbe8521d9a51e7310b45e3449

Powered by Google App Engine
This is Rietveld 408576698