Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1318663003: X87: Correctify instanceof and make it optimizable. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Correctify instanceof and make it optimizable. port 5d875a57fa2e65c1a4a6b50aeb23c38299c3cfbc (r30342). original commit message: The previous hack with HInstanceOfKnownGlobal was not only slower, but also very brittle and required a lot of weird hacks to support it. And what's even more important it wasn't even correct (because a map check on the lhs is never enough for instanceof). The new implementation provides a sane runtime implementation for InstanceOf plus a fast case in the InstanceOfStub, combined with a proper specialization in the case of a known global in CrankShaft, which does only the prototype chain walk (coupled with a code dependency on the known global). As a drive-by-fix: Also fix the incorrect Object.prototype.isPrototypeOf implementation. R=weiliang.lin@intel.com BUG= Committed: https://crrev.com/3aeed04dc265ce3a5f0d244a6cf3e1fca670b0e0 Cr-Commit-Position: refs/heads/master@{#30376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -427 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +95 lines, -220 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +39 lines, -108 lines 0 comments Download
M src/x87/lithium-x87.h View 3 chunks +16 lines, -27 lines 0 comments Download
M src/x87/lithium-x87.cc View 2 chunks +11 lines, -19 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +2 lines, -5 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 2 chunks +3 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
chunyang.dai
PTAL.
5 years, 3 months ago (2015-08-26 05:50:29 UTC) #1
Weiliang
lgtm
5 years, 3 months ago (2015-08-26 09:32:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318663003/1
5 years, 3 months ago (2015-08-26 09:32:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 09:56:44 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 09:57:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3aeed04dc265ce3a5f0d244a6cf3e1fca670b0e0
Cr-Commit-Position: refs/heads/master@{#30376}

Powered by Google App Engine
This is Rietveld 408576698