Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1318653004: Never move unbreakable blocks that are at the top of a column / page. (Closed)

Created:
5 years, 3 months ago by mstensho (USE GERRIT)
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Never move unbreakable blocks that are at the top of a column / page. That's just going to leave a column / page blank, without fitting any content better. If the block is too tall to fit in the current column / page, it's going to be just as too tall for the next one as well. BUG=526098 R=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
A LayoutTests/fast/multicol/unbreakable-block-too-tall-at-column-start.html View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/unbreakable-block-too-tall-at-column-start-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
5 years, 3 months ago (2015-08-31 12:20:34 UTC) #1
Julien - ping for review
lgtm
5 years, 3 months ago (2015-09-03 14:31:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318653004/1
5 years, 3 months ago (2015-09-03 14:31:16 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/64637)
5 years, 3 months ago (2015-09-03 17:27:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318653004/1
5 years, 3 months ago (2015-09-03 17:29:46 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 18:49:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201732

Powered by Google App Engine
This is Rietveld 408576698