Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1318653002: Attempt to fix mouse input issues after a sequence of touch presses. (Closed)

Created:
5 years, 4 months ago by ananta
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to fix mouse input issues after a sequence of touch presses. Users have reported mouse cursor vanishing and thus being unable to click anywhere in Chrome after performing a sequence of touch operations. The mouse cursor being hidden is normal and is done by Windows. However mouse events are not processed because we have pending touch events in our list. The touch event generation code has a bug where in it assumes the touch downs/ touch releases and moves would come in separately. However as per msdn releases and moves can be combined into one event which may explain the pending touch events. When we receive a release we erase the touch events associated with one ID from our list. If the touch release is combined with the move then this code would not execute thus causing the problem. BUG=513969 R=sky Committed: https://crrev.com/87d21af26764b63953c6bce39fb1119b4ee661ff Cr-Commit-Position: refs/heads/master@{#345706}

Patch Set 1 #

Patch Set 2 : Pass the correct input id to release touch state during touch release #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -24 lines) Patch
M ui/views/win/hwnd_message_handler.h View 1 chunk +12 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 3 chunks +36 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ananta
5 years, 4 months ago (2015-08-26 01:51:17 UTC) #2
sky
LGTM
5 years, 3 months ago (2015-08-26 15:36:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318653002/20001
5 years, 3 months ago (2015-08-26 21:53:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-26 22:40:31 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 22:41:51 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/87d21af26764b63953c6bce39fb1119b4ee661ff
Cr-Commit-Position: refs/heads/master@{#345706}

Powered by Google App Engine
This is Rietveld 408576698