content/public/renderer/content_renderer_client.h - Issue 1318643002: Pass the v8::Context through the willDestroyServiceWorkerContextOnWorkerThread event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/content_renderer_client.h

Issue 1318643002: Pass the v8::Context through the willDestroyServiceWorkerContextOnWorkerThread event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase against blink change Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_content_renderer_client.cc ('k') | content/renderer/service_worker/service_worker_context_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/content_renderer_client.h

diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h

index 8d840e9648067343bbea7f98cf9dc9d21a937d30..39de3aa8faabe30141e62dbfb9b21fb1757d122e 100644

--- a/content/public/renderer/content_renderer_client.h

+++ b/content/public/renderer/content_renderer_client.h

@@ -299,7 +299,9 @@ class CONTENT_EXPORT ContentRendererClient {

// Notifies that a service worker context will be destroyed. This function

// is called from the worker thread.

- virtual void WillDestroyServiceWorkerContextOnWorkerThread(const GURL& url) {}

+ virtual void WillDestroyServiceWorkerContextOnWorkerThread(

+ v8::Local<v8::Context> context,

+ const GURL& url) {}

};

} // namespace content