Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1318583002: Remove references to an old gyp variable that's no longer supported. (Closed)

Created:
5 years, 4 months ago by tommi (sloooow) - chröme
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to an old gyp variable that's no longer supported. BUG=463660 Committed: https://crrev.com/a1e4c970af90488466a54f29529b2741a433c104 Cr-Commit-Position: refs/heads/master@{#345562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -41 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M build/isolate.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser_tests.isolate View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/chrome_installer.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tommi (sloooow) - chröme
5 years, 4 months ago (2015-08-25 19:16:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318583002/1
5 years, 4 months ago (2015-08-25 19:17:10 UTC) #4
Nico
rs-lgtm
5 years, 4 months ago (2015-08-25 19:37:03 UTC) #5
tommi (sloooow) - chröme
On 2015/08/25 19:37:03, Nico wrote: > rs-lgtm Thanks. The code behind this feature was removed ...
5 years, 4 months ago (2015-08-25 19:42:10 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-25 20:55:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318583002/1
5 years, 4 months ago (2015-08-26 08:33:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-26 08:45:51 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 08:46:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1e4c970af90488466a54f29529b2741a433c104
Cr-Commit-Position: refs/heads/master@{#345562}

Powered by Google App Engine
This is Rietveld 408576698