Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1318573006: [Cronet] Add support for Proxy Auto Config (PAC) script (Closed)

Created:
5 years, 3 months ago by xunjieli
Modified:
4 years, 10 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Add support for Proxy Auto Config (PAC) script Android system has a local http proxy server to evaluate PAC scripts. Since Cronet does not depend on V8 for PAC scripts, this CL changes so that we use this http proxy server address and port instead of PAC script URLs. This CL follows the approach that Android WebView used in crrev.com/742023003. BUG=527646 Committed: https://crrev.com/93a7ff793a87269f7556cc8c3541219e984c5073 Cr-Commit-Position: refs/heads/master@{#350029}

Patch Set 1 #

Patch Set 2 : self review #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 2 3 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
xunjieli
Hi Paul, PTAL, but take your time. Unfortunately, we don't have a way to write ...
5 years, 3 months ago (2015-09-04 18:20:54 UTC) #2
pauljensen
lgtm
5 years, 3 months ago (2015-09-09 14:53:10 UTC) #3
pauljensen
BTW I think this will conflict with https://codereview.chromium.org/1290243007/
5 years, 3 months ago (2015-09-09 14:54:41 UTC) #4
xunjieli
On 2015/09/09 14:54:41, pauljensen wrote: > BTW I think this will conflict with https://codereview.chromium.org/1290243007/ Thanks ...
5 years, 3 months ago (2015-09-10 15:15:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1318573006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1318573006/60001
5 years, 3 months ago (2015-09-21 21:19:55 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-21 21:42:06 UTC) #9
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/93a7ff793a87269f7556cc8c3541219e984c5073 Cr-Commit-Position: refs/heads/master@{#350029}
5 years, 3 months ago (2015-09-21 21:42:57 UTC) #10
fujunweitongx
4 years, 10 months ago (2016-02-19 02:07:22 UTC) #11
Message was sent while issue was closed.
> We should follow WebView's example https://codereview.chromium.org/742023003/,
to set up support for PAC in Cronet.
How to set up PAC?

Powered by Google App Engine
This is Rietveld 408576698