Change first() and second() in CSSPairValue to return const references

Source/core/css/CSSBasicShapes.cpp

 /*
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 47 matching lines @@
         result.append(centerX);
         result.appendLiteral(separator);
         result.append(centerY);
     }
     result.append(')');
     return result.toString();
 }
 
 static String serializePositionOffset(const CSSValuePair& offset, const CSSValuePair& other)
 {
-    if ((toCSSPrimitiveValue(offset.first())->getValueID() == CSSValueLeft && toCSSPrimitiveValue(other.first())->getValueID() == CSSValueTop)
-        || (toCSSPrimitiveValue(offset.first())->getValueID() == CSSValueTop && toCSSPrimitiveValue(other.first())->getValueID() == CSSValueLeft))
-        return offset.second()->cssText();
+    if ((toCSSPrimitiveValue(offset.first()).getValueID() == CSSValueLeft && toCSSPrimitiveValue(other.first()).getValueID() == CSSValueTop)
+        || (toCSSPrimitiveValue(offset.first()).getValueID() == CSSValueTop && toCSSPrimitiveValue(other.first()).getValueID() == CSSValueLeft))
+        return offset.second().cssText();
     return offset.cssText();
 }
 
 static PassRefPtrWillBeRawPtr<CSSValuePair> buildSerializablePositionOffset(PassRefPtrWillBeRawPtr<CSSValue> offset, CSSValueID defaultSide)
 {
     CSSValueID side = defaultSide;
     RefPtrWillBeRawPtr<CSSPrimitiveValue> amount = nullptr;
 
     if (!offset) {
         side = CSSValueCenter;
     } else if (offset->isPrimitiveValue() && toCSSPrimitiveValue(offset.get())->isValueID()) {
         side = toCSSPrimitiveValue(offset.get())->getValueID();
     } else if (offset->isValuePair()) {
-        side = toCSSPrimitiveValue(toCSSValuePair(offset.get())->first())->getValueID();
-        amount = toCSSPrimitiveValue(toCSSValuePair(offset.get())->second());
+        side = toCSSPrimitiveValue(toCSSValuePair(*offset).first()).getValueID();
+        amount = &toCSSPrimitiveValue(toCSSValuePair(*offset).second());
     } else {
         amount = toCSSPrimitiveValue(offset.get());
     }
 
     if (side == CSSValueCenter) {
         side = defaultSide;
         amount = cssValuePool().createValue(50, CSSPrimitiveValue::UnitType::Percentage);
     } else if ((side == CSSValueRight || side == CSSValueBottom)
         && amount->isPercentage()) {
         side = defaultSide;
@@ skipping 251 matching lines @@
                     result.append(verticalRadii[i]);
                 }
             }
         }
     }
     result.append(')');
 
     return result.toString();
 }
 
-static inline void updateCornerRadiusWidthAndHeight(CSSValuePair* cornerRadius, String& width, String& height)
+static inline void updateCornerRadiusWidthAndHeight(const CSSValuePair* cornerRadius, String& width, String& height)
 {
     if (!cornerRadius)
         return;
 
-    width = cornerRadius->first() ? cornerRadius->first()->cssText() : String("0");
-    if (cornerRadius->second())
-        height = cornerRadius->second()->cssText();
+    width = cornerRadius->first().cssText();
+    height = cornerRadius->second().cssText();
 }
 
 String CSSBasicShapeInset::cssText() const
 {
     String topLeftRadiusWidth;
     String topLeftRadiusHeight;
     String topRightRadiusWidth;
     String topRightRadiusHeight;
     String bottomRightRadiusWidth;
     String bottomRightRadiusHeight;
@@ skipping 43 matching lines @@
     visitor->trace(m_left);
     visitor->trace(m_topLeftRadius);
     visitor->trace(m_topRightRadius);
     visitor->trace(m_bottomRightRadius);
     visitor->trace(m_bottomLeftRadius);
     CSSBasicShape::trace(visitor);
 }
 
 } // namespace blink